Skip to content

[HDRP] Remove Fake GTAO bounce on the occlusion when used for direct lighting #5836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 2, 2021
Merged

[HDRP] Remove Fake GTAO bounce on the occlusion when used for direct lighting #5836

merged 5 commits into from
Oct 2, 2021

Conversation

sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Sep 29, 2021 •
edited
Loading

Purpose of this PR

Get feedback from the artists that AO is not strong enough when enabled on direct lighting. This is due to incorrectly applying Jimenez GTAO multibounce trick on direct lighting. This PR remove the call to multibounce for direct lighting

Testing status

Validated with Seb Lachambre during exploration of ambient occlusion tutorial

Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@sebastienlagarde sebastienlagarde marked this pull request as ready for review October 2, 2021 08:38
@sebastienlagarde sebastienlagarde merged commit f0149cb into master Oct 2, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-ambient-occlusion branch October 2, 2021 15:45
sebastienlagarde added a commit that referenced this pull request Oct 3, 2021
@sebastienlagarde
[HDRP] Remove Fake GTAO bounce on the occlusion when used for direct …
ab75e11 
…lighting #5836
@sebastienlagarde sebastienlagarde mentioned this pull request Oct 3, 2021
Merged
sebastienlagarde added a commit that referenced this pull request Oct 3, 2021
@sebastienlagarde @arttu-peltonen
@eturquin @pierre-unity @johnpars
[Backport 21.2][HDRP] Backport various PRs (#5875)
9e0ab52 
* Add missing DisallowMultipleComponent attribute in AdditionalData components #5859

* [HDRP][Path Tracing] Slight robustness improvement for sample rescaling #5800

* recaptured reflection probes, updated normals on 2nd room's floor (#5873)

* Hair Documentation Pass (#5868)

* Hair Documentation Pass

* Add the images

* Apply various feedback to the documentation

* Fix small typo

* Update the OSX reference image (forgot to add it previous PR, causing failure) and rerun Yamato

* Update the tooltips

* [HDRP] Remove Fake GTAO bounce on the occlusion when used for direct lighting #5836

* Update 5014_VolumetricCloudsBanding.png

* Update 2307_Shadow_VeryHigh.png

Co-authored-by: Arttu Peltonen <77337829+arttu-peltonen@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: pierre-unity <39901544+pierre-unity@users.noreply.github.com>
Co-authored-by: John Parsaie <johnpa@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@FrancescoC-unity FrancescoC-unity FrancescoC-unity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-2021.1 HDRP testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sebastienlagarde @FrancescoC-unity