Add missing DisallowMultipleComponent attribute in AdditionalData components #5859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
arttu-peltonen
changed the title
arttu-peltonen
force-pushed
the
bugfix/disallow-multiple-additionaldata-components
branch
from
2ada214 to
4c6620f
Compare
RSlysz
approved these changes
Sep 30, 2021
sebastienlagarde
approved these changes
Sep 30, 2021
alex-vazquez
approved these changes
Sep 30, 2021
arttu-peltonen
force-pushed
the
bugfix/disallow-multiple-additionaldata-components
branch
from
4c6620f to
237a5f1
Compare
arttu-peltonen
deleted the
bugfix/disallow-multiple-additionaldata-components
branch
sebastienlagarde
pushed a commit
that referenced
this pull request
Oct 3, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Oct 3, 2021
* Add missing DisallowMultipleComponent attribute in AdditionalData components #5859 * [HDRP][Path Tracing] Slight robustness improvement for sample rescaling #5800 * recaptured reflection probes, updated normals on 2nd room's floor (#5873) * Hair Documentation Pass (#5868) * Hair Documentation Pass * Add the images * Apply various feedback to the documentation * Fix small typo * Update the OSX reference image (forgot to add it previous PR, causing failure) and rerun Yamato * Update the tooltips * [HDRP] Remove Fake GTAO bounce on the occlusion when used for direct lighting #5836 * Update 5014_VolumetricCloudsBanding.png * Update 2307_Shadow_VeryHigh.png Co-authored-by: Arttu Peltonen <77337829+arttu-peltonen@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: pierre-unity <39901544+pierre-unity@users.noreply.github.com> Co-authored-by: John Parsaie <johnpa@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixes https://fogbugz.unity3d.com/f/cases/1365879/.
AdditionalData components are associated with components that themselves only allow one instance of the component per gameobject (Camera, Light and Reflection Probe) . Therefore the AdditionalData components need to follow the same rule - the attribute was missing from
HDAdditionalReflectionDataandHDAdditionalLightData, so this PR adds them.Testing status
Checked that after the fix, you can no longer add multiple instances of these additionaldata components via "paste component as new".
Also I checked that the attribute were already present for
HDAdditionalCameraDatacomponent, as well asUniversalAdditionalCameraDataandUniversalAdditionalLightData. Therefore this should be low risk.