HDRP Template - Fixed reflection probes and floor normals #5873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
pierre-unity
changed the title
sebastienlagarde
approved these changes
Oct 1, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Oct 3, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Oct 3, 2021
* Add missing DisallowMultipleComponent attribute in AdditionalData components #5859 * [HDRP][Path Tracing] Slight robustness improvement for sample rescaling #5800 * recaptured reflection probes, updated normals on 2nd room's floor (#5873) * Hair Documentation Pass (#5868) * Hair Documentation Pass * Add the images * Apply various feedback to the documentation * Fix small typo * Update the OSX reference image (forgot to add it previous PR, causing failure) and rerun Yamato * Update the tooltips * [HDRP] Remove Fake GTAO bounce on the occlusion when used for direct lighting #5836 * Update 5014_VolumetricCloudsBanding.png * Update 2307_Shadow_VeryHigh.png Co-authored-by: Arttu Peltonen <77337829+arttu-peltonen@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: pierre-unity <39901544+pierre-unity@users.noreply.github.com> Co-authored-by: John Parsaie <johnpa@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR fixes a few visual issues in the template.
The reflections have been recaptured, as some reflection probes got corrupted eventually and didn't capture the correct transmission on the leaves.
It also fixes slightly off normals on the floor of the 2nd room, which skewed reflections unwantedly.
Comments to reviewers
Changes are minimal and very low risk. You can enable SSR and check that the 2nd room's reflection on the floor aren't broken, and check that the reflection of the leaves are not too green like they used to be.