Skip to content

Add missing DisallowMultipleComponent attribute in AdditionalData components #5859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Add missing DisallowMultipleComponent attribute in AdditionalData components #5859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f380a2
Add DisallowMultipleComponent to HDAdditionalReflectionData and HDAdd…
arttu-peltonen Sep 30, 2021
237a5f1
Changelog
arttu-peltonen Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed Probe volume debug exposure compensation to match the Lighting debug one.
- Fixed lens flare occlusion issues with TAA. (1365098)
- Fixed misleading text and improving the eye scene material samples. (case 1368665)
- Fixed missing DisallowMultipleComponent annotations in HDAdditionalReflectionData and HDAdditionalLightData (case 1365879).

## [13.0.0] - 2021-09-01

Expand Down
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDAdditionalLightData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ struct TimelineWorkaround
/// </summary>
[HDRPHelpURLAttribute("Light-Component")]
[AddComponentMenu("")] // Hide in menu
[DisallowMultipleComponent]
[RequireComponent(typeof(Light))]
[ExecuteAlways]
public partial class HDAdditionalLightData : MonoBehaviour, ISerializationCallbackReceiver, IAdditionalData
Expand Down
1 change: 1 addition & 0 deletions ...ender-pipelines.high-definition/Runtime/Lighting/Reflection/HDAdditionalReflectionData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ namespace UnityEngine.Rendering.HighDefinition
/// </summary>
[HDRPHelpURLAttribute("Reflection-Probe")]
[AddComponentMenu("")] // Hide in menu
[DisallowMultipleComponent]
[RequireComponent(typeof(ReflectionProbe))]
public sealed partial class HDAdditionalReflectionData : HDProbe, IAdditionalData
{
Expand Down