Fix Hybrid V2 compatibility for URP Unlit#605
Merged
Conversation
stramit
approved these changes
May 26, 2020
phi-lira
approved these changes
May 28, 2020
JussiKnuuttila
added a commit
that referenced
this pull request
Jun 17, 2020
* Fix Hybrid V2 incompatibility in URP Unlit shader.
stramit
pushed a commit
that referenced
this pull request
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
The URP Unlit shader was missing the DOTS_INSTANCING_ON keyword to make it compatible with Hybrid V2, and the shader model 4.5 mode that is required to make it work.
Testing status
Manual Tests
HybridURPSamples test project in dots repository.