[Shader Graph] [8.x.x] HotFix HDRP Attributes struct #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Backports behavior from master and 9.x.x, where the vertex attributes from every master node are always generated. It's a performance hit, but one that we can optimize later.
Fixes case 1250275
Testing status
Manual Tests
Created new shaders using every HDRP master node. Connected a vector property to the Vertex Normal and Vertex Tangent slot. Confirmed that when saving, the error no longer reproduces. Generated a shader and confirmed that the attributes struct are generate the needed properties.
Automated Tests
No tests in this PR, but I've made a note in our Favro board to add tests later. We can add tests now, but I didn't want the tests to block the merge as this is an urgent shipstopper for the next package release.
Links
Yamato: (Select your branch) https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics
Comments to reviewers