Skip to content

[Shader Graph] [8.x.x] HotFix HDRP Attributes struct #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2020
Merged

[Shader Graph] [8.x.x] HotFix HDRP Attributes struct #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ The version number for this package has increased due to a version update of a r

### Fixed
- Fixed a cause of NaN when a normal of 0-length is generated (usually via shadergraph).
- Fixed a bug where not all entries were generated for the Attributes Struct in Shader Graph shaders. (case 1250275)

## [8.1.0] - 2020-04-21

Expand Down
4 changes: 2 additions & 2 deletions com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ struct UInt32_4
internal struct AttributesMesh
{
[Semantic("POSITION")] Vector3 positionOS;
[Semantic("NORMAL")][Optional] Vector3 normalOS;
[Semantic("TANGENT")][Optional] Vector4 tangentOS; // Stores bi-tangent sign in w
[Semantic("NORMAL")] Vector3 normalOS;
[Semantic("TANGENT")] Vector4 tangentOS; // Stores bi-tangent sign in w
[Semantic("TEXCOORD0")][Optional] Vector4 uv0;
[Semantic("TEXCOORD1")][Optional] Vector4 uv1;
[Semantic("TEXCOORD2")][Optional] Vector4 uv2;
Expand Down