Skip to content

[2021.2] Fix shadow rendering correctly to work with shader stripping in WebGl#6343

Merged
phi-lira merged 2 commits into
2021.2/stagingfrom
2021.2/universal/fix-webgl-strip
Nov 24, 2021
Merged

[2021.2] Fix shadow rendering correctly to work with shader stripping in WebGl#6343
phi-lira merged 2 commits into
2021.2/stagingfrom
2021.2/universal/fix-webgl-strip

Conversation

@lukaschod
Copy link
Copy Markdown
Contributor

@lukaschod lukaschod commented Nov 19, 2021

Purpose of this PR

Backport #6300

@lukaschod lukaschod requested review from a team as code owners November 19, 2021 12:30
@github-actions
Copy link
Copy Markdown

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%2Fall-urp.yml%23PR_URP_2021.2
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@lukaschod lukaschod changed the title Setting valid shadow texture even if it is not sampled. As GL expects… [2021.2] Setting valid shadow texture even if it is not sampled. As GL expects… Nov 19, 2021
@github-actions
Copy link
Copy Markdown

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@lukaschod lukaschod changed the title [2021.2] Setting valid shadow texture even if it is not sampled. As GL expects… [2021.2] Fix shadow rendering correctly to work with shader stripping in WebGl Nov 19, 2021
@lukaschod lukaschod requested a review from phi-lira November 19, 2021 13:22
@lukaschod
Copy link
Copy Markdown
Contributor Author

Build URP_PostPro on iPhone_Metal_il2cpp_Linear_Standalone_build_Player on version
https://unity-ci.cds.internal.unity3d.com/job/9989413
exitCode: 138

ShaderGraph on Linux_Vulkan_Standalone_mono_Linear on version 2021.2
ShaderGraph on Win_DX11_Standalone_mono_Linear on version 2021.2
https://unity-ci.cds.internal.unity3d.com/job/10078725
ShaderGraphGraphicsTests.MathNodes

ShaderGraph on OSX_Metal_playmode_mono_Linear on version 2021.2
https://unity-ci.cds.internal.unity3d.com/job/10043234
Instability

URP_Terrain on Android_Vulkan_Standalone_il2cpp_Linear on version 2021.2
https://unity-ci.cds.internal.unity3d.com/job/9997330
UniversalGraphicsTests.035_Shader_TerrainShaders

No new failures, will wait for #6300

Copy link
Copy Markdown
Contributor

@ernestasKupciunas ernestasKupciunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The issue is fixed. Verified using the repro steps written in FB case(https://fogbugz.unity3d.com/f/cases/1381881/).
@lukaschod since this is a regression, please do a root cause analysis.

@lukaschod
Copy link
Copy Markdown
Contributor Author

lukaschod commented Nov 22, 2021

@ernestasKupciunas

What is the current workflow for root cause analysis? I remember it changed.

@phi-lira phi-lira merged commit 1f873d2 into 2021.2/staging Nov 24, 2021
@phi-lira phi-lira deleted the 2021.2/universal/fix-webgl-strip branch November 24, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants