[VFX] Fix instability with GUITests #6438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use common helper to avoid conflict writing twice on the same VFXAsset
- Split several batches for block test - Avoid storage of m_ViewController (it makes the test complex to follow) - Avoid closing VFXViewWindow between each test (it changes focus) - Fix incorrect OutputTest : it wasn't testing anything since the first output is a StaticMeshOutput (which doesn't allow any VFXBlock))
ExperimentCreateAllBlocksTiming(True,True) (524.566s) --- ApplyChange : True - Blocks 2;366.6056 4;280.8626 8;438.5445 16;916.79 32;2161.929 64;5800.3852 128;19399.343 256;81146.7971 384;144797.5553 512;259999.4175 ExperimentCreateAllBlocksTiming(True,False) (150.551s) --- ApplyChange : True - Operators 2;195.8352 4;262.6614 8;380.9485 16;546.6944 32;1052.9504 64;2302.2815 128;5838.3726 256;18521.1908 384;39612.1396 512;73306.4304 ApplyChange : False - Blocks 2;158.5336 4;170.5459 8;177.3936 16;171.1138 32;205.7508 64;303.08 128;512.1027 256;1204.1919 384;2270.6415 512;3770.7946 ExperimentCreateAllBlocksTiming(False,False) (12.354s) --- ApplyChange : False - Operators 2;146.4963 4;147.5193 8;154.3424 16;170.8592 32;216.6918 64;311.6344 128;564.5528 256;1327.3833 384;2454.0963 512;3980.0222
TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/VFXGUITests.cs
Show resolved
Hide resolved
TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/VFXGUITests.cs
Outdated
Show resolved
Hide resolved
TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/VFXGUITests.cs
Outdated
Show resolved
Hide resolved
TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/VFXGUITests.cs
Show resolved
Hide resolved
TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/VFXGUITests.cs
Outdated
Show resolved
Hide resolved
TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/VFXGUITests.cs
Outdated
Show resolved
Hide resolved
julienamsellem
approved these changes
Dec 1, 2021
PaulDemeulenaere
added a commit
that referenced
this pull request
Dec 1, 2021
It fixes test in edit mode
|
The issue about VFX_URP isn't related to this change, see this conversation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix instability leading to a timeout in VFXGUITest, the number of listed block in InitializeContext increased from 348 to 1068.
It leads to exploding test time, and sometimes a time out on Yamato.
This PR doesn't resolve the performance issue but is only splitting the CreateAllBlocksTest test in several batch of 256 blocks.
Bonus:
VFXTestCommon.MakeTemporaryGraphAPI instead of legacy set of GUITest asset (we were writing several time on the same asset before)Testing status
Locally 🟢 (and the split of CreateAllBlocksTest make it faster to run, ~300s to ~120s, not ideal neither)
Yamato 🟢 (always)
Comments to reviewers
See also this Conversation & Quick performance analysis