-
Notifications
You must be signed in to change notification settings - Fork 856
Pro-artistry: Add a callback for the Rotated Shadow Map technique. #6503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pro-artistry: Add a callback for the Rotated Shadow Map technique. #6503
Conversation
…he HDRP repository.
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks simple enough for me
} | ||
|
||
public delegate Matrix4x4 CustomViewCallback(Matrix4x4 lightLocalToWorldMatrix); | ||
public CustomViewCallback CustomViewCallbackEvent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add documentation for public API :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add a changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added :)
/!\ This PR is a draft, just a proposition for the HDRP team. /!\
Reminder of the
Rotated Shadow Map
technique:https://drive.google.com/file/d/18_Px85w9-_VxRXKBoo1UnVy1OUpN1Ri_/view?usp=sharing
Here's a link to the prototype we developed. Also, this technique has been used in several Disney projects (Big Hero / Baymax) and Sherman (1 & 2), proving it's efficiency.
https://github.com/YohannVaastUnity/HDRP_RotatedShadowMap/pull/1
Here's a quick gif of the accumulation process:

Regarding the PR
Thanks!