Skip to content

Pro-artistry: Add a callback for the Rotated Shadow Map technique. #6503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 16, 2021
Merged

Pro-artistry: Add a callback for the Rotated Shadow Map technique. #6503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dc9ced2
Add a callback so the Rotated Shadow Map technique works outside of t…
YohannV Dec 6, 2021
6f2447c
Documentation for public API
YohannV Dec 15, 2021
3a3e3ac
Merge branch 'master' into prototype/rotated-shadow-map-callback
YohannV Dec 15, 2021
a1cef71
Add changelog
YohannV Dec 15, 2021
dc8a834
Apply formatting changes
Dec 15, 2021
8c93b52
Merge branch 'master' into prototype/rotated-shadow-map-callback
sebastienlagarde Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Added a button in the Probe Volume Baking window to open the Probe Volume debug panel.
- Added importance sampling of the sky in path tracing (aka environment sampling).
- Added the overlay render queue to custom passes.
- Added a callback to override the View matrix of Spot Lights.
- Added Expose SSR parameters to control speed rejection from Motion Vector including computing Motion Vector in World Space.

### Fixed
Expand Down
10 changes: 10 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDAdditionalLightData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1979,6 +1979,12 @@ public int areaLightEmissiveMeshLayer
}
}

/// <summary> A callback allowing the creation of a new Matrix4x4 based on the lightLocalToWorld matrix </summary>
public delegate Matrix4x4 CustomViewCallback(Matrix4x4 lightLocalToWorldMatrix);

/// <summary> Change the View matrix for Spot Light </summary>
public CustomViewCallback CustomViewCallbackEvent;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add documentation for public API :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add a changelog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added :)


void OnDestroy()
{
if (lightIdxForCachedShadows >= 0) // If it is within the cached system we need to evict it.
Expand Down Expand Up @@ -2224,6 +2230,10 @@ internal void UpdateShadowRequestData(HDCamera hdCamera, HDShadowManager manager
out shadowRequest.view, out invViewProjection, out shadowRequest.projection,
out shadowRequest.deviceProjection, out shadowRequest.deviceProjectionYFlip, out shadowRequest.splitData
);
if (CustomViewCallbackEvent != null)
{
shadowRequest.view = CustomViewCallbackEvent(visibleLight.localToWorldMatrix);
}
break;
case HDLightType.Directional:
UpdateDirectionalShadowRequest(manager, shadowSettings, visibleLight, cullResults, viewportSize, shadowIndex, lightIndex, cameraPos, shadowRequest, out invViewProjection);
Expand Down