Fix for some post effects not scaling correctly when dynamic resolution is enabled on a camera's target texture#7383
Merged
sebastienlagarde merged 3 commits intomasterfrom Dec 15, 2022
Conversation
…was not handled properly if the camera has a target texture that has dynamic resolution enabled
ryanhy-unity
approved these changes
Jun 9, 2022
ryanhy-unity
left a comment
There was a problem hiding this comment.
Since post processing tests and manual verification done already I ran through some XR platforms not covered in the automated tests. Verified Oculus and Open XR runtimes both work fine and pass automated graphics tests. I was unable to verify Vulkan due to an existing issue however.
mikesfbay
approved these changes
Jun 9, 2022
sebastienlagarde
approved these changes
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Fixes https://fogbugz.unity3d.com/f/cases/1166603/ where some post effects were not scaling correctly when dynamic resolution is enabled on a camera's target texture. Dynamic resolution can be enabled on a camera (https://docs.unity3d.com/ScriptReference/Camera-allowDynamicResolution.html) or on a render texture (https://docs.unity3d.com/ScriptReference/RenderTexture-useDynamicScale.html), which means it can be enabled for a camera using Camera.allowDynamicResolution or Camera.targetTexture.useDynamicScale. We check both these cases internally but this isn't exposed in script, so we have to manually check both cases in ppv2.
Testing status
Tested manually against https://fogbugz.unity3d.com/f/cases/1166603/ on Windows/DX12.
Ran yamato postprocessing tests
Comments to reviewers