FIX: PlayerInputManager joining not working with kb&mouse schemes (#1023). #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1023.
Regression was introduced in 1.0.0-preview.4. The changes to control scheme selection now caused the code to no longer find the right control scheme to use when joining from one device but having a scheme that required more than one device. This also surfaced another problem where the system made it possible to join a player, then fail to set it up correctly, and finally end up with a situation where the player has no
InputUser, no devices, and activates all bindings from all control schemes -- and thus interferes with all other players.Both issues are fixed in this PR. Tests are updated.
Also adds a new "Simple Multiplayer" sample with a bare-bones local multiplayer setup (unlike "Simple Demo", it is really simple...) with split-screen.
Uncovered a bug in
ArrayHelpers.EraseSliceWithCapacityin the process. Also fixed in the PR.