FIX: Input devices sometimes marked as disabled on reconnect#1524
Merged
FIX: Input devices sometimes marked as disabled on reconnect#1524
Conversation
…en disconnected devices are reconnected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a
InputDeviceis disconnected while an app is out-of-focus and the the device'sInputDevice.DeviceFlags.DisabledWhileInBackgroundflag is set, the flag will remain set upon reconnect even if the app has since regained focus. This results in the device incorrectly appearing as disabled until the next focus change event. This PR corrects this by clearing theInputDevice.DeviceFlags.DisabledWhileInBackgroundon reconnection of a device. If the app is still out-of-focus during reconnect and the flag is valid, this will be detected and set as normal during the call toInputManager.AddDevice().Changes made
Fixed an issue where
InputDevice.enabledcould return false when a device was disconnected while an application was out-of-focus and then re-connected when in-focusChecklist
Before review:
Changed,Fixed,Addedsections.([case %number%](https://issuetracker.unity3d.com/issues/...)).Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.