Skip to content

Tracked pose driver icon#1575

Merged
ekcoh merged 4 commits intodevelopfrom
tracked-pose-driver-icon
Aug 25, 2022
Merged

Tracked pose driver icon#1575
ekcoh merged 4 commits intodevelopfrom
tracked-pose-driver-icon

Conversation

@ekcoh
Copy link
Copy Markdown
Collaborator

@ekcoh ekcoh commented Aug 22, 2022

Description

Added missing tracked pose driver icon: https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-262

Changes made

Added existing icon resources bundled with editor into package. Updated scripts to reference those icons.

Notes

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@ekcoh ekcoh requested a review from chris-massie August 23, 2022 08:52
@ekcoh
Copy link
Copy Markdown
Collaborator Author

ekcoh commented Aug 25, 2022

Thanks @vrdave-unity, @chris-massie, @andrew-oc, @jamesmcgill for reviewing, will merge this today.

@ekcoh ekcoh merged commit 8ff4ac3 into develop Aug 25, 2022
@ekcoh ekcoh deleted the tracked-pose-driver-icon branch August 25, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants