Improving state debugger to show live values, binary, etc#1583
Merged
Improving state debugger to show live values, binary, etc#1583
Conversation
|
|
ekcoh
approved these changes
Sep 24, 2022
Collaborator
ekcoh
left a comment
ekcoh
left a comment
There was a problem hiding this comment.
LGTM, I think its a neat and useful improvement to the debugger. As a potential future additional improvement it might be useful to "fade out / mix back the color" changed bits/bytes over time (e.g. 2 seconds) - this doesn't need to be considered here.
| public static GUIStyle hexLabel = new GUIStyle | ||
| { | ||
| fontStyle = FontStyle.Normal, | ||
| font = Font.CreateDynamicFontFromOSFont("Courier", EditorStyles.label.fontSize + 2), |
Collaborator
There was a problem hiding this comment.
Related to comment of Courier in sync, see https://www.grputland.com/2012/08/font-stacks-that-look-similar-in.html#cour20120806 for platform specific options for linux, mac, win if there is a desire to use something else. However I think this is fine as is and I think its the right call to align with other editor monospaced representations if there is nothing bundled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improved our state debugger window.
Changes made
Added support for: