Skip to content

FIX: 'Type of instance in array does not match expected type' assertion (ISXB-282)#1591

Merged
jamesmcgill merged 1 commit intodevelopfrom
fix-assert-exiting-playmode
Oct 7, 2022
Merged

FIX: 'Type of instance in array does not match expected type' assertion (ISXB-282)#1591
jamesmcgill merged 1 commit intodevelopfrom
fix-assert-exiting-playmode

Conversation

@jamesmcgill
Copy link
Copy Markdown
Collaborator

Description

This (one character) fix prevents the Type of instance in array does not match expected type assertion triggering under certain circumstances.
Those circumstances being: disabling a PlayerInput component which has an action attached which contains both an Interaction and a Control Scheme.

Changes made

Ensure that during deferred binding resolution, if any change requested a full binding resolution, this could not be erased if subsequent binding resolution request were made that did not require it.
(In this case InputActionAsset.bindingMask property setter followed by InputActionAsset.devices property setter would trigger this)

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@jamesmcgill jamesmcgill requested a review from jimon October 6, 2022 14:26
@jamesmcgill jamesmcgill force-pushed the fix-assert-exiting-playmode branch from 8a2a389 to e90e27f Compare October 7, 2022 11:31
@jamesmcgill jamesmcgill merged commit cc33939 into develop Oct 7, 2022
@jamesmcgill jamesmcgill deleted the fix-assert-exiting-playmode branch October 7, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants