FIX: Allow InputSystem class to set runtime runInBackground field#1662
Merged
jfreire-unity merged 3 commits intodevelopfrom Mar 31, 2023
Merged
FIX: Allow InputSystem class to set runtime runInBackground field#1662jfreire-unity merged 3 commits intodevelopfrom
jfreire-unity merged 3 commits intodevelopfrom
Conversation
Collaborator
lyndon-unity
left a comment
There was a problem hiding this comment.
Seems reasonable but I don't know all the connection between platform packages and the main package to be sure this is the best way to handle it.
f59bdc5 to
b2e6a7f
Compare
f5dade2 to
53cf4e8
Compare
53cf4e8 to
303b655
Compare
Collaborator
Author
|
After going through all the options, I decided to go with the Public API direction for now. |
303b655 to
61beef2
Compare
martinh-unity
approved these changes
Mar 31, 2023
unity-cwells
approved these changes
Mar 31, 2023
MattWUnity3d
approved these changes
Mar 31, 2023
lyndon-unity
approved these changes
Mar 31, 2023
|
@jfreire-unity Yo. Sorry to butt in but this is a breaking change for anyone who is implementing the IInputRuntime interface. Just saying. Also hi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some platforms' background behavior isn't reflected in
Application.runInBackground. This PR exposesInputSystem.runInBackgroundto be called by those particular platforms to tell the Input System that the platform runs in the background.It should be considered for "internal use" only even though it is part of the public API.
Context: This is the alternative for the rejected PR #1648. Specific platforms can call this API as they wish, otherwise, we rely on
Application.runInBackgroundset in the Editor settings for platforms that allow being run in the background.Changed,Fixed,Addedsections.([case %number%](https://issuetracker.unity3d.com/issues/...)).Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.