NEW: add maps, actions and bindings via '+' button (ISX-1040)#1675
Merged
NEW: add maps, actions and bindings via '+' button (ISX-1040)#1675
Conversation
lyndon-unity
approved these changes
Apr 21, 2023
Collaborator
lyndon-unity
left a comment
There was a problem hiding this comment.
Looks like reasonable changes to implement the add functionality
Minor feedback on variable naming but I'm happy for that to land in follow up PR or essentially pre approve
jamesmcgill
approved these changes
Apr 24, 2023
Collaborator
jamesmcgill
left a comment
There was a problem hiding this comment.
Looks great @ritamerkl
In addition to @lyndon-unity's comments please rename the PR to something like:
NEW: add maps, actions and bindings via '+' button (ISX-1040)
Note the uppercase prefix and the Jira ticket at the end in parenthesis.
This will be used as the final commit message after squashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added '+' button on top of Map-View for adding new action maps. Also added a '+' button on top of the action view to add new action items. Added a '+' button for each action element to add new bindings.
Implemented UI and fuctionality.
Link to the ticket: ISX-1040
Changes made
Added: add maps, actions and bindings via the '+' buttons on the UI
Notes
Please write down any additional notes, remove the section if not applicable.
Checklist
Before review:
Changed,Fixed,Addedsections.([case %number%](https://issuetracker.unity3d.com/issues/...)).Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.