[2022.3] Change #ifdef to allow for displayIndex (multi-display) in Unity 2022.3#1686
Merged
jamesmcgill merged 1 commit intodevelopfrom Jun 8, 2023
Merged
[2022.3] Change #ifdef to allow for displayIndex (multi-display) in Unity 2022.3#1686jamesmcgill merged 1 commit intodevelopfrom
jamesmcgill merged 1 commit intodevelopfrom
Conversation
reapazor
requested review from
ekcoh,
jamesmcgill and
jfreire-unity
and removed request for
ekcoh
jamesmcgill
approved these changes
Jun 8, 2023
Collaborator
jamesmcgill
left a comment
jamesmcgill
left a comment
There was a problem hiding this comment.
Thanks @reapazor. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alters the #ifdef's that protect the displayIndex work to match supported Unity editor versions. It actually landed in late 2022.2 as well, but it was safer to use the UNITY_2022_3_OR_NEWER condition.
Changes made
#if UNITY_2023_1_OR_NEWERis now#if UNITY_2022_3_OR_NEWERfor displayIndex code