NEW: edit actions and bindings properties (ISX-1374, ISX-1126)#1691
Merged
NEW: edit actions and bindings properties (ISX-1374, ISX-1126)#1691
Conversation
…lete-actions-maps-bindings
…tions-maps-bindings # Conflicts: # Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/InputActionsTreeViewItem.cs
…ons-and-bindings # Conflicts: # Packages/com.unity.inputsystem/InputSystem/Editor/Internal/InputActionSerializationHelpers.cs # Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Commands/Commands.cs # Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/InputActionsEditorState.cs # Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ActionMapsView.cs # Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ActionsTreeView.cs # Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/CompositeBindingPropertiesView.cs # Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ContextMenu.cs # Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/InputActionsTreeViewItem.cs # Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/Selectors.cs
lyndon-unity
requested changes
Jun 22, 2023
Collaborator
lyndon-unity
left a comment
lyndon-unity
left a comment
There was a problem hiding this comment.
Looks reasonable. I've made a couple of queries so will pause before approving. Answers might mean no changes needed though.
ritamerkl
changed the title
lyndon-unity
approved these changes
Jun 28, 2023
Collaborator
lyndon-unity
left a comment
lyndon-unity
left a comment
There was a problem hiding this comment.
Good updates, minor comment added. Generally happy to approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
added the functionality to edit various fields for Actions, Bindings, Composites and Bindings in Composites.
Includes adding, editing, reordering and deleting of Interactions and Processors. See the Ticket here.
Another related ticket was done with this PR: https://jira.unity3d.com/browse/ISX-1126
Changes made
added:
Notes
Checklist
Before review:
Changed,Fixed,Addedsections.([case %number%](https://issuetracker.unity3d.com/issues/...)).Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.