Skip to content

Listen button fix for older unity versions (ISXB-535)#1717

Merged
ritamerkl merged 2 commits intodevelopfrom
ISXB-535-Listen-Button-older-versions-fix
Jul 24, 2023
Merged

Listen button fix for older unity versions (ISXB-535)#1717
ritamerkl merged 2 commits intodevelopfrom
ISXB-535-Listen-Button-older-versions-fix

Conversation

@ritamerkl
Copy link
Copy Markdown
Collaborator

Description

added conditional compilation for line to avoid older unity versions to throw a warning.

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@ritamerkl ritamerkl requested a review from lyndon-unity July 24, 2023 11:40
Copy link
Copy Markdown
Collaborator

@lyndon-unity lyndon-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable solution to the issue. Thank you.

@ritamerkl ritamerkl merged commit 68d2be6 into develop Jul 24, 2023
@ritamerkl ritamerkl deleted the ISXB-535-Listen-Button-older-versions-fix branch July 24, 2023 14:02
@sttz
Copy link
Copy Markdown

sttz commented Aug 23, 2023

The condition only works for the specific patch versions checked (2021.3.28 and 2022.3.1), not for any newer patch versions.

I'm running 2022.3.7 and the listen button is broken again, since the #if does not pass and ToolbarSeachTextField is used again.

The proper fix would to use UNITY_2021_3_OR_NEWER and then exclude all versions without the style name change, for 2022 e.g. !UNITY_2022_1 && !UNITY_2022_2 && !UNITY_2022_3_0. For 2021 this would have to check all 28 previous patch versions, so maybe a dynamic check would be more sensible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants