Release tests throws exceptions in InputSystem (ISXB-581)#1718
Merged
Release tests throws exceptions in InputSystem (ISXB-581)#1718
Conversation
lyndon-unity
approved these changes
Jul 26, 2023
Collaborator
lyndon-unity
left a comment
lyndon-unity
left a comment
There was a problem hiding this comment.
Looks like a good change - just the link to update
| - Fixed serialization migration in the Tracked Pose Driver component causing bindings to clear when prefabs are used in some cases ([case ISXB-512](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-512), [case ISXB-521](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-521)). | ||
| - Fixed Tracked Pose Driver to use `Transform.SetLocalPositionAndRotation` when available to improve performance. Based on the user contribution from [DevDunk](https://forum.unity.com/members/devdunk.4432119/) in a [forum post](https://forum.unity.com/threads/more-performant-tracked-pose-driver-solution-included.1462691). | ||
| - Fixed the `Clone` methods of `InputAction` and `InputActionMap` so it copies the Initial State Check flag (`InputAction.wantsInitialStateCheck`) of input actions. | ||
| - Fixed the "Release tests throws exception in InputSystem" bug ([case ISXB-581](https://jira.unity3d.com/browse/ISXB-581)). |
Collaborator
There was a problem hiding this comment.
You should use the public link here which is :
https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-581
(or
https://issuetracker.unity3d.com/issues/release-tests-fail-when-input-system-package-is-installed )
Collaborator
|
I see some 'inconclusive' results in the code analysis CI run but I don't think this is specific to this PR. Could be worth reviewing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixed this ticket by surrounding code with conditional compilation if the methods are not accessible (due they should be only used in development mode or in editor)
Checklist
Before review:
Changed,Fixed,Addedsections.([case %number%](https://issuetracker.unity3d.com/issues/...)).Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.