Skip to content

NEW: Only show matching binding-paths for selected control scheme (ISX-1549)#1724

Merged
ritamerkl merged 4 commits intodevelopfrom
ISX-1549-only-show-matching-paths-for-control-scheme
Aug 16, 2023
Merged

NEW: Only show matching binding-paths for selected control scheme (ISX-1549)#1724
ritamerkl merged 4 commits intodevelopfrom
ISX-1549-only-show-matching-paths-for-control-scheme

Conversation

@ritamerkl
Copy link
Copy Markdown
Collaborator

@ritamerkl ritamerkl commented Aug 8, 2023

Description

Like described in this ticket: for every selected binding, if the binding dropdown pop ups, it should only show the matching bindings to the current selected control scheme (if there is one).

Changes made

Added: reused existing methods to filter the binding paths to show in the UI

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@ritamerkl ritamerkl requested a review from jamesmcgill August 8, 2023 13:10
Copy link
Copy Markdown
Collaborator

@jamesmcgill jamesmcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, please hold off merging until v1.7.0

@ritamerkl ritamerkl merged commit bb2b109 into develop Aug 16, 2023
@ritamerkl ritamerkl deleted the ISX-1549-only-show-matching-paths-for-control-scheme branch August 16, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants