Skip to content

FIX: bindings presentation for control schemes (ISX-1132)#1725

Merged
ritamerkl merged 4 commits intodevelopfrom
ISX-1132-bindings-presentation-for-control-schemes
Aug 16, 2023
Merged

FIX: bindings presentation for control schemes (ISX-1132)#1725
ritamerkl merged 4 commits intodevelopfrom
ISX-1132-bindings-presentation-for-control-schemes

Conversation

@ritamerkl
Copy link
Copy Markdown
Collaborator

Description

Updated the action tree view to only show bindings that are included into the current selected control scheme. Also I corrected the {GLOBAL} identifier to only show up if no control scheme is assigned to a binding. The ticket can be found here, see the comments for details.

Changes made

fixed:

  • hiding bindings assigned to other control schemes if a control scheme is selected
  • showing global identifier only on bindings that are not assigned to any control scheme

Notes

As the feature seems not to work reliable good in the old UI there were misunderstandings on how this feature has to work, so a different solution was implemented before.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@ritamerkl ritamerkl requested a review from jamesmcgill August 9, 2023 12:27
Copy link
Copy Markdown
Collaborator

@jamesmcgill jamesmcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added a couple of comments.
Hold off merging until after the release please

@ritamerkl ritamerkl merged commit 6da7853 into develop Aug 16, 2023
@ritamerkl ritamerkl deleted the ISX-1132-bindings-presentation-for-control-schemes branch August 16, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants