FIX: bindings presentation for control schemes (ISX-1132)#1725
Merged
FIX: bindings presentation for control schemes (ISX-1132)#1725
Conversation
jamesmcgill
approved these changes
Aug 10, 2023
Collaborator
jamesmcgill
left a comment
There was a problem hiding this comment.
Looks good, added a couple of comments.
Hold off merging until after the release please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the action tree view to only show bindings that are included into the current selected control scheme. Also I corrected the {GLOBAL} identifier to only show up if no control scheme is assigned to a binding. The ticket can be found here, see the comments for details.
Changes made
fixed:
Notes
As the feature seems not to work reliable good in the old UI there were misunderstandings on how this feature has to work, so a different solution was implemented before.
Checklist
Before review:
Changed,Fixed,Addedsections.([case %number%](https://issuetracker.unity3d.com/issues/...)).Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.