ISX-1551 Make Project-Wide Actions and UITK editor available from 2022.3+#1729
Conversation
There was a problem hiding this comment.
Whats the reason to replace UNITY_INPUT_SYSTEM_ENABLE_GLOBAL_ACTIONS_API with UNITY_2020_2_OR_NEWER rather than changing the asmdef
I only ask as the other define UNITY_INPUT_SYSTEM_ENABLE_GLOBAL_ACTIONS_API is using the asm def rather than UNITY_2022_3_OR_NEWER
Why not use the same consistent approach ?
It sounds like you wanted to do this in stages and would prefer to replace the UNITY_INPUT_SYSTEM_ENABLE_GLOBAL_ACTIONS_API in a later commit.
I'm comfortable with this change
Regarding the note:
a decision will need to be made about having Project Wide Actions without UI TK support, since it is only available for 2022.3.
I think we've agreed that on slack. Its fine for project wide actions to only be supported in 2022.3 as its a new feature.
|
No need to merge this, #1735 deals with this already. |
Description
This PR makes the Project-Wide Actions and UITK available from 2022.3+. More in the notes below.
🔔 It targets the current WIP project wide actions branch #1720
Changes made
It removes
UNITY_INPUT_SYSTEM_UI_TK_ASSET_EDITORand replaces it withUNITY_2022_3_OR_NEWERsince UITK functionality is only available from 2022.3 forward.TreeViewwhich is only available from 2022.2 but we still get some errors due to the features we're using that are only stable in 2022.3. So it's more reasonable to enable it for 2022.3.For
UNITY_INPUT_SYSTEM_ENABLE_GLOBAL_ACTIONS_APII did not do the same. Rather I updated the.asmdefto make Project Wide Actions available from 2022.3 to match UI TK Asset Editor.api/global-actions-source-generators.I also didn't remove the feature flags yet. We could do that once we do a stable
1.8.0when both these features available have been tested and used more and are stable enough.Notes
Also, a decision will need to be made about having Project Wide Actions without UI TK support, since it is only available for 2022.3.
There's no point in having Project Wide Actions if the users cannot see them in the Project Settings. And at the moment there is no easy way to just use the IMGUI implementation of the Asset Editor and embed it in the Project Settings editor AFAIK.
Checklist
Before review:
Changed,Fixed,Addedsections.([case %number%](https://issuetracker.unity3d.com/issues/...)).Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.