Skip to content

Conversation

@Pauliusd01
Copy link
Collaborator

@Pauliusd01 Pauliusd01 commented Feb 2, 2024

Description

Changed the error type to warning, I agreed with the user report that from our own descriptions (https://www.foundations.unity.com/patterns/errors-and-messaging#Message-Types) the warning type is more fitting. But feel free to disagree if there's a good reason this is an error, will close it

Changes made

Please write down a short description of what changes were made.

Notes

Please write down any additional notes, remove the section if not applicable.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@Pauliusd01 Pauliusd01 requested a review from ekcoh February 2, 2024 09:09
@Pauliusd01 Pauliusd01 requested a review from ekcoh February 2, 2024 13:14
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems it needs to be updated from develop, then ok to merge

@Pauliusd01 Pauliusd01 merged commit 7ff4db3 into develop Feb 2, 2024
@Pauliusd01 Pauliusd01 deleted the Change-max-player-count-error-to-warning-ISXB-719 branch February 2, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants