Conversation
2b95f08 to
db17eb0
Compare
c1d97f6 to
7e1682b
Compare
…nputBindingComposite
700e766 to
486923b
Compare
chris-massie
reviewed
Aug 5, 2024
| RegisterCustomTypes(); | ||
| } | ||
|
|
||
| void RegisterCustomTypes(Type[] types) |
Collaborator
There was a problem hiding this comment.
Can we make sure to add a ProfilerMarker to track how long this takes?
Collaborator
Author
There was a problem hiding this comment.
good idea I will add that
Collaborator
There was a problem hiding this comment.
yeah, that sounds good. @chris-massie are you concerned with startup times with this change?
…action.cs Co-authored-by: Chris Massie <67029035+chris-massie@users.noreply.github.com>
…thub.com/Unity-Technologies/InputSystem into isxb-856-fix-editor-project-wide-actions
jfreire-unity
approved these changes
Aug 15, 2024
fixed changelog order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The static registration of custom processor, interaction, BindingComposite could lead to undefined behavior for project action if the static initiation doesn't occur in the right order which is by design hard to control.
Changes made
Add reflection to load custom InputProcessor, IInputInteraction and InputBindingComposite during the InputManage initialisation.
Added a profiler marker for this step.
Testing
local test + bug project
Risk
It add some time in the initialisation and register all derived type which was not the case before.
We may encounter some name collision and he doesn't have a way to disable the automatic discovery.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: