Skip to content

FIX: ControlScheme names with spaces treated as null (ISXB-547)#1962

Merged
Pauliusd01 merged 1 commit intodevelopfrom
isxb-547-empty-control-scheme
Jul 11, 2024
Merged

FIX: ControlScheme names with spaces treated as null (ISXB-547)#1962
Pauliusd01 merged 1 commit intodevelopfrom
isxb-547-empty-control-scheme

Conversation

@timkeo
Copy link
Copy Markdown
Collaborator

@timkeo timkeo commented Jul 10, 2024

Description

Fixes a minor UI bug in which the user can create a ControlScheme with a name consisting just of spaces. This is an invalid name string and causes various issues and should be handled the same as a null/empty string

Changes made

Updates the checks for null/empty string to also include OrWhiteSpace causing a default name to be used instead of the invalid string.

Testing

Verified the fix locally but didn't do any other testing.

Risk

A simple change with very low risk.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

A ControlScheme with only spaces is invalid and handled the same as a null/empty string: a default name is used instead.
@Pauliusd01 Pauliusd01 merged commit 264ad86 into develop Jul 11, 2024
@Pauliusd01 Pauliusd01 deleted the isxb-547-empty-control-scheme branch July 11, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants