FIX: ControlScheme names with spaces treated as null (ISXB-547)#1962
Merged
Pauliusd01 merged 1 commit intodevelopfrom Jul 11, 2024
Merged
FIX: ControlScheme names with spaces treated as null (ISXB-547)#1962Pauliusd01 merged 1 commit intodevelopfrom
Pauliusd01 merged 1 commit intodevelopfrom
Conversation
A ControlScheme with only spaces is invalid and handled the same as a null/empty string: a default name is used instead.
jfreire-unity
approved these changes
Jul 11, 2024
Pauliusd01
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a minor UI bug in which the user can create a ControlScheme with a name consisting just of spaces. This is an invalid name string and causes various issues and should be handled the same as a null/empty string
Changes made
Updates the checks for null/empty string to also include OrWhiteSpace causing a default name to be used instead of the invalid string.
Testing
Verified the fix locally but didn't do any other testing.
Risk
A simple change with very low risk.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: