Skip to content

CHANGE: Update ci to use new Package Verification Profile to generate errors#1965

Merged
stefanunity merged 14 commits intodevelopfrom
update-ci-apv2.0
Jul 18, 2024
Merged

CHANGE: Update ci to use new Package Verification Profile to generate errors#1965
stefanunity merged 14 commits intodevelopfrom
update-ci-apv2.0

Conversation

@stefanunity
Copy link
Copy Markdown
Collaborator

@stefanunity stefanunity commented Jul 17, 2024

Description

We need to start moving to the new package works workflow for our releases. This is a first step adding the new PVP package checks to our pack job.

Changes made

  • added new PVP execution to "Publish to Internal Registry (Dry Run)" yamato job
  • added .\yamato\PVPexemptions.json file that includes all the errors the package currently generates
  • any new errors will fail this job and you can see the report in the results tab of the job in yamato
  • our grandfathered exemptsions being added to the system at https://github.cds.internal.unity3d.com/unity/pets.pvp-catalog/pull/23
  • also fixed 2 small error categories as part of this PR (trainling spaces, wrong meta files)
  • PVP-40-1 will complain about [Unreleased] in our changelog but won't be a problem on stable branch where that section will not exist during our package release

Testing

Job runs and the exemption file is beingused for checking errors.

Risk

Low risk, just adding another step, all previous steps of the job work the same.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@stefanunity stefanunity marked this pull request as ready for review July 17, 2024 14:53
@stefanunity stefanunity requested a review from ritamerkl July 17, 2024 15:01
- Expanded editor and build insight analytics to cover ``.inputactions` asset editor usage, `InputSettings` and common component configurations.

### Changed
- Changed `DualSenseHIDInputReport` from internal to public visibility
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we remove this?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there were two Changed sections by mistake, I deleted one and this line also exists in the remaining section

@stefanunity stefanunity merged commit 21726c7 into develop Jul 18, 2024
@stefanunity stefanunity deleted the update-ci-apv2.0 branch July 18, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants