FIX: InputActionCodeGenerator if an action map is named debug (ISXB-851)#1968
Merged
Pauliusd01 merged 3 commits intodevelopfrom Jul 18, 2024
Merged
FIX: InputActionCodeGenerator if an action map is named debug (ISXB-851)#1968Pauliusd01 merged 3 commits intodevelopfrom
Pauliusd01 merged 3 commits intodevelopfrom
Conversation
Pauliusd01
approved these changes
Jul 18, 2024
Collaborator
Pauliusd01
left a comment
There was a problem hiding this comment.
LGTM, no errors when the "Debug" map name is used and I can interact with that map by adding actions/duplicating, renaming it again, etc without issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When generation an input action with an action map named "Debug" it generate a code that doesn't compile.
https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-851
Assets\InputSystem.cs(65,15): error CS1061: 'InputSystem.DebugActions' does not contain a definition for 'Assert' and no accessible extension method 'Assert' accepting a first argument of type 'InputSystem.DebugActions' could be found (are you missing a using directive or an assembly reference?)Changes made
Added the prefix UnityEngine prefix to Debug to remove the ambiguity in the generated code
Testing
local test
Risk
Please describe the potential risks of your changes for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: