Skip to content

FIX: ISX-1183 fixed and reenabled UITests for InputSystemUIInputModule.#1974

Merged
bmalrat merged 6 commits intodevelopfrom
isx-1183-reenableuitests
Aug 7, 2024
Merged

FIX: ISX-1183 fixed and reenabled UITests for InputSystemUIInputModule.#1974
bmalrat merged 6 commits intodevelopfrom
isx-1183-reenableuitests

Conversation

@benoitalain
Copy link
Copy Markdown
Collaborator

@benoitalain benoitalain commented Jul 29, 2024

Description

Jira ticket: https://jira.unity3d.com/browse/ISX-1138

Changes made

Fixed and re-enabled UITests.UI_CanOperateUIToolkitInterface_UsingInputSystemUIInputModule tests on Windows and MacOS.

My change is mainly to tick the "multiline" checkbox for the TextField, which makes the scrollview vertical scroller appear.

Testing

Ran the reactivated tests locally (on Windows).

Risk

I don't know why those tests have different results on different platforms. It's possible that my tests pass locally now but still fail on Yamato.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@benoitalain benoitalain changed the title ISX-1183: fixed and reenabled UITests for InputSystemUIInputModule. FIX: ISX-1183 fixed and reenabled UITests for InputSystemUIInputModule. Jul 29, 2024
@benoitalain benoitalain requested a review from bmalrat July 29, 2024 20:46
[TestCase(UIPointerBehavior.SingleUnifiedPointer, ExpectedResult = 1)]
#if (UNITY_ANDROID || UNITY_IOS || UNITY_TVOS) || (TEMP_DISABLE_UITOOLKIT_TEST && (UNITY_STANDALONE_OSX || UNITY_STANDALONE_WIN))
#if UNITY_ANDROID || UNITY_IOS || UNITY_TVOS
[Ignore("Currently fails on the farm but succeeds locally on Note 10+; needs looking into.")]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it still fail on the farm after your changes?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any fail at all in the current state of the branch. All the tests that are failing are also failing on develop.

@bmalrat bmalrat merged commit c022f7f into develop Aug 7, 2024
@bmalrat bmalrat deleted the isx-1183-reenableuitests branch August 7, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants