FIX: ISX-1183 fixed and reenabled UITests for InputSystemUIInputModule.#1974
Merged
FIX: ISX-1183 fixed and reenabled UITests for InputSystemUIInputModule.#1974
Conversation
bmalrat
reviewed
Aug 1, 2024
| [TestCase(UIPointerBehavior.SingleUnifiedPointer, ExpectedResult = 1)] | ||
| #if (UNITY_ANDROID || UNITY_IOS || UNITY_TVOS) || (TEMP_DISABLE_UITOOLKIT_TEST && (UNITY_STANDALONE_OSX || UNITY_STANDALONE_WIN)) | ||
| #if UNITY_ANDROID || UNITY_IOS || UNITY_TVOS | ||
| [Ignore("Currently fails on the farm but succeeds locally on Note 10+; needs looking into.")] |
Collaborator
There was a problem hiding this comment.
does it still fail on the farm after your changes?
Collaborator
Author
There was a problem hiding this comment.
I didn't see any fail at all in the current state of the branch. All the tests that are failing are also failing on develop.
bmalrat
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira ticket: https://jira.unity3d.com/browse/ISX-1138
Changes made
Fixed and re-enabled UITests.UI_CanOperateUIToolkitInterface_UsingInputSystemUIInputModule tests on Windows and MacOS.
My change is mainly to tick the "multiline" checkbox for the TextField, which makes the scrollview vertical scroller appear.
Testing
Ran the reactivated tests locally (on Windows).
Risk
I don't know why those tests have different results on different platforms. It's possible that my tests pass locally now but still fail on Yamato.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: