FIX: Fixed 'OnDrop' event not called when 'IPointerDownHandler' is also listened. (ISXB-1014)#1988
Merged
FIX: Fixed 'OnDrop' event not called when 'IPointerDownHandler' is also listened. (ISXB-1014)#1988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When IPointerDownHandler is registered it enable the clic detector and after that PR #1911 it trigger all the time even if there is no pointerClickHandler.
var isClick = eventData.pointerClick == pointerClickHandler && eventData.eligibleForClick;Is always true since pointerClickHandler and eventData.pointerClick are null.
Changes made
Added a null check to prevent a bad clic detection.
Also changed the code to prevent calling
ExecuteEvents.GetEventHandler<IPointerClickHandler>(currentOverGo);twiceTesting
Tested with client project and some extra test with multiple MonoBehavior that use a combinaison of
IBeginDragHandler, IDragHandler, IDropHandler, IEndDragHandler, IPointerDownHandler, IPointerEnterHandler, IPointerExitHandler, IPointerClickHandler
Risk
Please describe the potential risks of your changes for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: