Skip to content

Conversation

@Secticide
Copy link
Collaborator

Description

Fixes ISXB-1171.

The issue was caused by the on change handler causing a full UI rebuild of the editor window when it was not required. The fix required added a new enum which told the UI system if a rebuild was necessary - defaulting to rebuilding since this was the previous default.

Testing status & QA

This was tested locally using the provided project. The change is localised to the composite binding part of the window and so I don't believe additional QA would be required.

Overall Product Risks

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

The only concern I have with this solution is - do we know of any instances where changes to the UI would require a complete rebuild?

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekcoh ekcoh requested a review from stefanunity December 18, 2024 14:41
… the state container dispatch and view base OnStateChanged - this gives us control over which state changes cause a UI rebuild
@Secticide Secticide force-pushed the isxb-1171/ia-editor-double-click-fix branch from 826d9b2 to 5943351 Compare January 9, 2025 11:19
@ritamerkl ritamerkl merged commit 58bd3ec into develop Jan 9, 2025
77 checks passed
@ritamerkl ritamerkl deleted the isxb-1171/ia-editor-double-click-fix branch January 9, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants