-
Notifications
You must be signed in to change notification settings - Fork 329
FIX: Modify logic to get active player settings object to work with build profiles (ISXB-1430) #2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
19248d5 to
d4b0a5b
Compare
d4b0a5b to
bbdb187
Compare
ekcoh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, lets make sure to replace this code with proper API when available.
Pauliusd01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, checked the build profile overriding input backend repro as well as regular backend switching. Tested on editors mentioned as reproducible and not reproducible since the if added is broad, didn't seem to cause any issues on the non reproducible versions though so that's fine
|
Thanks @marcus-winter42 . Once this http://github.cds.internal.unity3d.com/unity/unity/pull/61739 lands, we should update the package code for Unity 6.1 |
ccdb6ff to
fe8ccd6
Compare
Description
This PR fixes ISXB-1430 by introducing a workaround to properly determine the currently active PlayerSettings. Previously a list of all exisiting PlayerSettings objects was fetched and the first one was assumed to be the active one.
Testing status & QA
Verified locally that the infinit reimport loop no longer occurs with the provided reproducer project.
Overall Product Risks
Comments to reviewers
None.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: