Skip to content

Conversation

@marcus-winter42
Copy link
Collaborator

@marcus-winter42 marcus-winter42 commented Feb 12, 2025

Description

This PR fixes ISXB-1430 by introducing a workaround to properly determine the currently active PlayerSettings. Previously a list of all exisiting PlayerSettings objects was fetched and the first one was assumed to be the active one.

Testing status & QA

Verified locally that the infinit reimport loop no longer occurs with the provided reproducer project.

Overall Product Risks

  • Complexity: 1
  • Halo Effect: 1

Comments to reviewers

None.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@unity-cla-assistant
Copy link

unity-cla-assistant commented Feb 12, 2025

CLA assistant check
All committers have signed the CLA.

@marcus-winter42 marcus-winter42 changed the title Bugfix/ISXB-1430 - Fix logic to get active platform settings object to work with build profiles FIX: ISXB-1430 - Fix logic to get active platform settings object to work with build profiles Feb 12, 2025
@jfreire-unity jfreire-unity changed the title FIX: ISXB-1430 - Fix logic to get active platform settings object to work with build profiles FIX: Fix logic to get active platform settings object to work with build profiles (ISXB-1430) Feb 13, 2025
@marcus-winter42 marcus-winter42 changed the title FIX: Fix logic to get active platform settings object to work with build profiles (ISXB-1430) FIX: Modify logic to get active platform settings object to work with build profiles (ISXB-1430) Feb 13, 2025
@marcus-winter42 marcus-winter42 changed the title FIX: Modify logic to get active platform settings object to work with build profiles (ISXB-1430) FIX: Modify logic to get active player settings object to work with build profiles (ISXB-1430) Feb 13, 2025
@marcus-winter42 marcus-winter42 self-assigned this Feb 13, 2025
@marcus-winter42 marcus-winter42 marked this pull request as ready for review February 13, 2025 14:05
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets make sure to replace this code with proper API when available.

Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked the build profile overriding input backend repro as well as regular backend switching. Tested on editors mentioned as reproducible and not reproducible since the if added is broad, didn't seem to cause any issues on the non reproducible versions though so that's fine

@jfreire-unity
Copy link
Collaborator

Thanks @marcus-winter42 . Once this http://github.cds.internal.unity3d.com/unity/unity/pull/61739 lands, we should update the package code for Unity 6.1

@marcus-winter42 marcus-winter42 merged commit 2163cc1 into develop Feb 14, 2025
94 checks passed
@marcus-winter42 marcus-winter42 deleted the fix-isxb-1430 branch February 14, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants