Skip to content

Conversation

@jfreire-unity
Copy link
Collaborator

@jfreire-unity jfreire-unity commented Dec 1, 2025

Description

This PR fixes failing currently jobs on Android. The only difference I've seen between passing and failing Android jobs was the UTR version being used. Failing jobs used the version 1.43 and passing jobs used 1.42.
To unblock us for now, I'll pin Android jobs to 1.42 as well and then we can understand what's happening for 1.43 that doesn't work.

Testing status & QA

CI passed for one job, let's see if all Unity versions jobs pass as well.

Overall Product Risks

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@jfreire-unity jfreire-unity marked this pull request as ready for review December 1, 2025 09:22
@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Dec 1, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

The PR involves a trivial change to a CI configuration file, adding a single environment variable to pin a dependency version, along with a minor formatting adjustment.
🏅 Score: 95

The change effectively addresses the stated CI failure by pinning the UTR version, consistent with the existing pattern for iOS. Adding a code comment explaining the reason for the pin (similar to the iOS block) would be beneficial for future maintenance.
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Dec 1, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@codecov-github-com
Copy link

codecov-github-com bot commented Dec 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop    #2297   +/-   ##
========================================
  Coverage    77.95%   77.96%           
========================================
  Files          477      477           
  Lines        97416    97416           
========================================
+ Hits         75943    75949    +6     
+ Misses       21473    21467    -6     
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.54% <ø> (ø)
inputsystem_MacOS_2022.3_project 75.49% <ø> (ø)
inputsystem_MacOS_6000.0 5.32% <ø> (ø)
inputsystem_MacOS_6000.0_project 77.41% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.2 5.32% <ø> (ø)
inputsystem_MacOS_6000.2_project 77.41% <ø> (ø)
inputsystem_MacOS_6000.3 5.32% <ø> (ø)
inputsystem_MacOS_6000.3_project 77.41% <ø> (ø)
inputsystem_MacOS_6000.4 5.33% <ø> (ø)
inputsystem_MacOS_6000.4_project 77.42% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.5 5.33% <ø> (ø)
inputsystem_MacOS_6000.5_project 77.42% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_2022.3 5.54% <ø> (ø)
inputsystem_Ubuntu_2022.3_project 75.29% <ø> (ø)
inputsystem_Ubuntu_6000.0 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.0_project 77.21% <ø> (ø)
inputsystem_Ubuntu_6000.2 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.2_project 77.21% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.3 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.3_project 77.22% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.4 5.33% <ø> (ø)
inputsystem_Ubuntu_6000.4_project 77.22% <ø> (ø)
inputsystem_Ubuntu_6000.5 5.33% <ø> (ø)
inputsystem_Ubuntu_6000.5_project 77.22% <ø> (ø)
inputsystem_Windows_2022.3 5.54% <ø> (ø)
inputsystem_Windows_2022.3_project 75.62% <ø> (ø)
inputsystem_Windows_6000.0 5.32% <ø> (ø)
inputsystem_Windows_6000.0_project 77.53% <ø> (ø)
inputsystem_Windows_6000.2 5.32% <ø> (ø)
inputsystem_Windows_6000.2_project 77.53% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3 5.32% <ø> (ø)
inputsystem_Windows_6000.3_project 77.53% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.4 5.33% <ø> (ø)
inputsystem_Windows_6000.4_project 77.54% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.5 5.33% <ø> (ø)
inputsystem_Windows_6000.5_project 77.54% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@K-Tone K-Tone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out and unblocking the PR pipes, awesome Joao!!

@jfreire-unity jfreire-unity merged commit aaaf3cc into develop Dec 1, 2025
125 checks passed
@jfreire-unity jfreire-unity deleted the ci/attemp-to-fix-failing-android-jobs-utr-142 branch December 1, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants