FIX: Extra empty lines added in the control bindings drop-down for some mouse buttons #2299
Conversation
| if (!item.children.Any()) | ||
| { | ||
| if (!item.IsSeparator()) | ||
| if (!item.IsSeparator() && item.searchableName.Length > 0) |
There was a problem hiding this comment.
That's it basically. We would like not to search in non-searchable items because they end up as empty lines in the displayed list in the end.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
PR Code Suggestions ✨Explore these optional code suggestions:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
|||||||||
K-Tone
changed the title
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2299 +/- ##
===========================================
- Coverage 77.95% 77.95% -0.01%
===========================================
Files 477 476 -1
Lines 97419 97405 -14
===========================================
- Hits 75943 75928 -15
- Misses 21476 21477 +1 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ekcoh
left a comment
ekcoh
left a comment
There was a problem hiding this comment.
Thanks for fixing this. Change makes a lot of sense IMO.
K-Tone
force-pushed
the
anthony/isxb-1677-mouse-bindings
branch
from
5ac5411 to
2acc063
Compare
Pauliusd01
left a comment
Pauliusd01
left a comment
There was a problem hiding this comment.
LGTM tried binding and using in-game all of the mouse and some keyboard keys (both via listen and picking in the list) Did not notice any more empty space entries or other issues
Description
This PR aims at fixing the following problem with empty entries in the input control list that is better illustrated by a gif below. Practically, many of the mouse buttons will add an extra empty line:
The reason that happens is that we somehow have both searchable and not searchable advanced drop-down items for mouse in the list. The non-searchable have no name, and thus they're shown as empty lines.
In this PR I opted for not populating the drop-down hierarchy with search results that are non-searchable for whatever reason.
Case ISXB-1677
Testing status & QA
After fixing, I've basically followed the repro steps to make sure the problem is no longer there. I have a mouse with side buttons so it's easier to check on my end.
Overall Product Risks
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.