FIX: UI inconsistencies - Add buttons use add icon in input actions window (1/x)

[josepmariapujol-unity]

Description

Fixing UI inconsistencies (1/x)

• Add buttons use add icon and add dropdown icon
• Removed button background
• Removed "+" text button

Before:

After:

JIRA: ISX-2340

Testing status & QA

Manually tested by clicking on the buttons.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

• Complexity: Low
• Halo Effect: Low

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

[u-pr-agent]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶 ISX-2340 - Partially compliant Compliant requirements: Add buttons use add icon. Add more icon is also available when multiple ADD actions are available. Non-compliant requirements: Auto-Save toggle has the wrong padding. The Label has min-width of 120px. No “Shadow” section headers. Toolbar use toolbar style. Action properties should use reordable lists. Consider using a single helpbox to explain default setting. Requires further human verification: Verify that the "add more" icon is correctly used in context (PropertiesView).

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪ The PR contains straightforward UI changes, but requires verification that all modified UXML elements have corresponding C# logic updates to apply the new icon classes, which might be missing for list items.

🏅 Score: 85 The PR addresses the specific "add button" requirements effectively, but introduces a potential bug with a list item button becoming invisible and propagates a typo in class names.

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Possible Issue The text="+" attribute was removed from add-new-binding-button, but there is no corresponding change in the C# code diff (e.g., in a BindItem method) to apply the .add-button class to this element. If the class is not added, the button will be rendered as an empty, invisible element when displayed. <ui:Button display-tooltip-when-elided="true" enable-rich-text="false" name="add-new-binding-button" style="opacity: 1; background-color: rgba(255, 255, 255, 0); border-left-color: rgba(255, 255, 255, 0); border-right-color: rgba(255, 255, 255, 0); border-top-color: rgba(255, 255, 255, 0); border-bottom-color: rgba(255, 255, 255, 0); display: none; align-items: flex-end; align-self: auto; flex-direction: row-reverse;" /> Typo in Class Name The class name string "add-binging-button" contains a typo ("binging" instead of "binding"). This typo is also present in the USS file. While likely pre-existing in the CSS, this PR propagates the typo into the C# code. Consider fixing the spelling in both CSS and C# if possible. addInteractionButton.AddToClassList(EditorGUIUtility.isProSkin ? "add-binging-button-dark-theme" : "add-binging-button"); Theme Switching Issue The code uses EditorGUIUtility.isProSkin at initialization time to select the class name. If the user switches the Editor theme (Light/Dark) at runtime, the button icon will not update until the window is reloaded. Using USS theme selectors or variables (if supported by the setup) is generally preferred over hardcoded C# checks. m_AddActionMapButton.AddToClassList(EditorGUIUtility.isProSkin ? "add-button-dark-theme" : "add-button");

Update review

---

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

[u-pr-agent]

PR Code Suggestions ✨

No code suggestions found for the PR.

[codecov-github-com]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2302      +/-   ##
===========================================
- Coverage    77.95%   77.94%   -0.01%     
===========================================
  Files          477      476       -1     
  Lines        97419    97408      -11     
===========================================
- Hits         75943    75925      -18     
- Misses       21476    21483       +7     

Flag	Coverage Δ
inputsystem_MacOS_2022.3	5.54% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_2022.3_project	75.49% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.0	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.0_project	77.36% <100.00%> (-0.05%)	⬇️
inputsystem_MacOS_6000.2	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.2_project	77.36% <100.00%> (-0.05%)	⬇️
inputsystem_MacOS_6000.3	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.3_project	77.36% <100.00%> (-0.05%)	⬇️
inputsystem_MacOS_6000.4	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.4_project	77.37% <100.00%> (+<0.01%)	⬆️
inputsystem_MacOS_6000.5	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.5_project	77.36% <100.00%> (-0.05%)	⬇️
inputsystem_Ubuntu_2022.3	5.54% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_2022.3_project	75.28% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.0	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.0_project	77.16% <100.00%> (-0.06%)	⬇️
inputsystem_Ubuntu_6000.2	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.2_project	77.16% <100.00%> (-0.05%)	⬇️
inputsystem_Ubuntu_6000.3	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.3_project	77.16% <100.00%> (-0.06%)	⬇️
inputsystem_Ubuntu_6000.4	5.33% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.4_project	77.17% <100.00%> (-0.06%)	⬇️
inputsystem_Ubuntu_6000.5	5.33% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.5_project	77.18% <100.00%> (-0.05%)	⬇️
inputsystem_Windows_2022.3	5.54% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_2022.3_project	75.61% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.0	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.0_project	77.49% <100.00%> (-0.06%)	⬇️
inputsystem_Windows_6000.2	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.2_project	77.48% <100.00%> (-0.06%)	⬇️
inputsystem_Windows_6000.3	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.3_project	77.49% <100.00%> (-0.06%)	⬇️
inputsystem_Windows_6000.4	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.4_project	77.49% <100.00%> (-0.05%)	⬇️
inputsystem_Windows_6000.5	5.32% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.5_project	77.49% <100.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...tem/Editor/UITKAssetEditor/Views/ActionMapsView.cs	62.34% <100.00%> (+0.23%)	⬆️
...em/Editor/UITKAssetEditor/Views/ActionsTreeView.cs	47.38% <100.00%> (+0.08%)	⬆️
...tem/Editor/UITKAssetEditor/Views/PropertiesView.cs	63.15% <100.00%> (+0.32%)	⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Pauliusd01]

Clashes with #2158 which I also preferred

Also, the icons look worse/thinner on the input actions asset window compared to the one in the project settings:

[josepmariapujol-unity]

Clashes with #2158 which I also preferred

Also, the icons look worse/thinner on the input actions asset window compared to the one in the project settings: <img alt="image" width="2000" height="439" src="https://private-user-images.githubusercontent.com/54306142/526568811-bc490b15-dab0-4414-b833-363350b139ca.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjU4MDQ1MjUsIm5iZiI6MTc2NTgwNDIyNSwicGF0aCI6Ii81NDMwNjE0Mi81MjY1Njg4MTEtYmM0OTBiMTUtZGFiMC00NDE0LWI4MzMtMzYzMzUwYjEzOWNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjE1VDEzMTAyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM5NjhjZjExZjAyZWU5MWE4OWI5ZjA0NjAxMTMyNDhjNjY5ZWEwZDNkMzgyZDhhNDBhZDlhNzI3MDMzNTlkYjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.BRH5f7pzH1zgq5W

iDkfECiVMcQjij_3KnCgQhgf-744">

It must be a windows specific since on mac it shows the same icon. Let me check it out on my other machine

[josepmariapujol-unity]

Clashes with #2158 which I also preferred

Also, the icons look worse/thinner on the input actions asset window compared to the one in the project settings:

Background can be reverted yet I would like that we follow UI/UX unity standards as much as we can

[josepmariapujol-unity]

Requested @MartinNadeau to review UI/UX changes made in this PR