FIX: uum 134737 corrupt input action asset editor window on restart

[Darren-Kelly-Unity]

Description

Fix an issue where the input action asset editor window was corrupted / in a broken state after restarting Unity when there was a pending change on the input action asset.

Ticket:
https://jira.unity3d.com/browse/UUM-134737

Testing status & QA

Tested manually for now, the sequence of events is too hard to test due to needing to restart Unity to cause the issue.

Overall Product Risks

Not much risk here.

• Complexity: 1
• Halo Effect: 1

Comments to reviewers

There is a repro video in the ticket linked above.
How to reproduce:

1. Create a new URP project
2. Open the “InputSystem_Actions“ default Input Actions Asset (to have the window open after step 3)
3. Add a binding to an action.
   4 Restart the project
4. In the Input Actions Editor window, add a binding to any action, and expand the dropdown in the Action Properties
5. Observe the options

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

[u-pr]

I have reviewed the changes and found several issues that should be addressed. Most notably, there is a potential state leak when the editor quit operation is aborted by other listeners, which could lead to data loss in subsequent window close attempts. Additionally, there are a few instances of commented-out code in the test files that should be cleaned up.

Summary of Findings

• High Importance: 1 bug regarding editor quit state persistence.
• Low Importance: 2 issues regarding dead/commented-out code in tests.

_{🤖 Helpful? 👍/👎}

[codecov-github-com]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...Editor/UITKAssetEditor/InputActionsEditorWindow.cs	0.00%	5 Missing ⚠️

@@             Coverage Diff             @@
##           develop    #2371      +/-   ##
===========================================
- Coverage    77.90%   77.89%   -0.01%     
===========================================
  Files          476      481       +5     
  Lines        97613    97681      +68     
===========================================
+ Hits         76048    76093      +45     
- Misses       21565    21588      +23     

Flag	Coverage Δ
inputsystem_MacOS_2022.3	5.50% <0.00%> (-0.03%)	⬇️
inputsystem_MacOS_2022.3_project	75.40% <0.00%> (+<0.01%)	⬆️
inputsystem_MacOS_6000.0	5.28% <0.00%> (-0.03%)	⬇️
inputsystem_MacOS_6000.0_project	77.30% <0.00%> (+0.01%)	⬆️
inputsystem_MacOS_6000.3	5.28% <0.00%> (-0.03%)	⬇️
inputsystem_MacOS_6000.3_project	77.30% <0.00%> (+0.01%)	⬆️
inputsystem_MacOS_6000.4	5.28% <0.00%> (-0.03%)	⬇️
inputsystem_MacOS_6000.4_project	77.31% <0.00%> (+0.01%)	⬆️
inputsystem_MacOS_6000.5	5.28% <0.00%> (-0.03%)	⬇️
inputsystem_MacOS_6000.5_project	77.31% <0.00%> (+<0.01%)	⬆️
inputsystem_MacOS_6000.6	5.28% <0.00%> (-0.03%)	⬇️
inputsystem_MacOS_6000.6_project	77.31% <0.00%> (+<0.01%)	⬆️
inputsystem_Ubuntu_2022.3_project	75.20% <0.00%> (+<0.01%)	⬆️
inputsystem_Ubuntu_6000.0	5.28% <0.00%> (-0.03%)	⬇️
inputsystem_Ubuntu_6000.0_project	77.11% <0.00%> (+0.01%)	⬆️
inputsystem_Ubuntu_6000.3	5.28% <0.00%> (-0.03%)	⬇️
inputsystem_Ubuntu_6000.3_project	77.11% <0.00%> (+0.01%)	⬆️
inputsystem_Ubuntu_6000.4	5.29% <0.00%> (-0.03%)	⬇️
inputsystem_Ubuntu_6000.4_project	77.12% <0.00%> (+<0.01%)	⬆️
inputsystem_Ubuntu_6000.5	5.29% <0.00%> (-0.03%)	⬇️
inputsystem_Ubuntu_6000.5_project	77.11% <0.00%> (+<0.01%)	⬆️
inputsystem_Ubuntu_6000.6	5.29% <0.00%> (-0.03%)	⬇️
inputsystem_Ubuntu_6000.6_project	77.11% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_2022.3	5.50% <0.00%> (-0.03%)	⬇️
inputsystem_Windows_2022.3_project	75.53% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_6000.0	5.28% <0.00%> (-0.03%)	⬇️
inputsystem_Windows_6000.0_project	77.43% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_6000.3	5.28% <0.00%> (-0.03%)	⬇️
inputsystem_Windows_6000.3_project	77.43% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_6000.4	5.28% <0.00%> (-0.03%)	⬇️
inputsystem_Windows_6000.4_project	77.43% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_6000.5	5.28% <0.00%> (-0.03%)	⬇️
inputsystem_Windows_6000.5_project	77.43% <0.00%> (+0.01%)	⬆️
inputsystem_Windows_6000.6	5.28% <0.00%> (-0.03%)	⬇️
inputsystem_Windows_6000.6_project	77.43% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...Editor/UITKAssetEditor/InputActionsEditorWindow.cs	52.96% <0.00%> (-1.69%)	⬇️

... and 6 files with indirect coverage changes

[Darren-Kelly-Unity]

/review

[u-pr]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶 UUM-134737 - Partially compliant Compliant requirements: Fix: Prevent the Input Actions Editor window from entering a corrupted/broken state after restart (domain reload) when the asset had pending edits. Non-compliant requirements: Scope: Issue affects the default InputSystem_Actions asset specifically; editor should behave correctly without needing workarounds (opening a different asset or restarting the editor window). Requires further human verification: Repro: Restart Unity with the Input Actions Editor window opened on the default InputSystem_Actions asset, then add a binding and verify all expected binding/path options are shown. Scope: Issue affects the default InputSystem_Actions asset specifically; editor should behave correctly without needing workarounds (opening a different asset or restarting the editor window).

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪ Very small change, but it affects editor state reconstruction after domain reload and should be validated against the specific restart repro.

🏅 Score: 90 The change is minimal and plausibly fixes the state corruption by correcting initialization order, but it lacks automated coverage and needs manual restart verification.

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Init Order The new order creates a new InputActionsEditorState before setting analytics; confirm the InputActionsEditorState constructor (or any code it triggers) does not require m_Analytics to be non-null during construction, and that analytics/state are preserved correctly across domain reload. { workingCopy = InputActionAssetManager.CreateWorkingCopy(asset); m_State = new InputActionsEditorState(m_State, new SerializedObject(workingCopy)); if (m_State.m_Analytics == null) m_State.m_Analytics = analytics; m_AssetObjectForEditing = workingCopy; State Consistency When m_AssetObjectForEditing is null, the state is rebuilt from a workingCopy and then m_AssetObjectForEditing is assigned; confirm no downstream logic assumes m_AssetObjectForEditing was set prior to rebuilding m_State (e.g., state-derived caches pointing at the correct object). { workingCopy = InputActionAssetManager.CreateWorkingCopy(asset); m_State = new InputActionsEditorState(m_State, new SerializedObject(workingCopy)); if (m_State.m_Analytics == null) m_State.m_Analytics = analytics; m_AssetObjectForEditing = workingCopy; }

Update review

---

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr

[ekcoh]

Fix looks good to me but I think u-pr has a valid comment about side-effects that IMO could be addressed on this PR before landing to get rid of that problem.

[Pauliusd01]

/test_plan

[u-pr]

Test Plan

• Test plan approved by PR author
• Test execution in progress
• Test execution complete
• Ready for merge

---

Summary of Changes & Risk Assessment

Summary of Changes

This PR fixes a state corruption issue in the Input Action Asset editor window that occurs after a Unity restart (or domain reload) when an asset has unsaved changes. The fix corrects the initialization order in InputActionsEditorWindow.cs by ensuring the InputActionsEditorState is instantiated before attempting to restore its analytics reference.

Risk Assessment

• High Risk Areas: None identified.
• Medium Risk Areas: None identified.
• Low Risk Areas: Editor state restoration, Input Action Asset persistence during domain reloads, Analytics tracking in the editor.

---

Test Scenarios

Functional Testing

• Verify Fix (Restart Repro):
  1. Open an Input Action Asset (e.g., the default InputSystem_Actions).
  2. Add a new binding to any action (leave it unsaved).
  3. Restart the Unity Editor.
  4. Upon restart, verify the window is open, the pending change is present, and adding/expanding binding properties functions correctly without UI corruption.
• Verify Analytics Restoration: Ensure that after a domain reload, the m_State.m_Analytics field is correctly populated by the window's analytics property, as the logic for this assignment was moved after the state constructor.

Regression Testing

• Standard Asset Opening: Verify that opening an Input Action Asset normally (when no window was previously open) still functions correctly and initializes state as expected.
• Undo/Redo After Restoration: Perform the restart repro; once restored, verify that Undo (Ctrl+Z) correctly removes the pre-restart pending change and that the UI updates immediately.
• Multiple Windows: Open two different Input Action Assets in separate windows, modify both, restart, and verify both windows restore their respective states correctly without crosstalk.

Edge Cases

• Deleted Asset on Restart: Modify an asset, keep the window open, close Unity, delete the .inputactions file manually from the file system, and restart Unity. Verify the window handles the "Failed to load asset" exception gracefully (ref: InputActionsEditorWindow.cs:L211).

---

_{💡 This test plan updates automatically when /test_plan is run on new commits. If you have any feedback, please reach out in #ai-qa}

---

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr

[Pauliusd01]

Rechecked the latest commit by having unsaved changes and quitting in different ways, the window worked correctly on restart (To expand on what I did was close the editor with don't save, save, and force close and then checked whether input actions window is acting correctly on restart. If you meant something else let me know and I'll check again)