FIX: ArrayHelpers.Merge used the comparer incorrectly [ISXB-1790]#2377
Merged
FIX: ArrayHelpers.Merge used the comparer incorrectly [ISXB-1790]#2377
Conversation
…s arguments - comparer.Equals(secondValue) was comparing against comparer instance. - Use comparer.Equals(x, secondValue) to check if any merged element x equals secondValue. - Add Utilities_MergeWithComparer_UsesComparerToDeduplicate test. Made-with: Cursor
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The review identified a high-importance logic bug where the index parameter is ignored in HaveDuplicateReferences, potentially leading to incorrect results for sub-range checks. Additionally, there is a medium-importance performance concern regarding heap allocations in the Merge method and a low-importance suggestion for type constraints to prevent boxing.
🤖 Helpful? 👍/👎
Packages/com.unity.inputsystem/InputSystem/Utilities/ArrayHelpers.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Utilities/ArrayHelpers.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Utilities/ArrayHelpers.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2377 +/- ##
===========================================
+ Coverage 77.92% 78.11% +0.19%
===========================================
Files 482 483 +1
Lines 97755 98784 +1029
===========================================
+ Hits 76175 77170 +995
- Misses 21580 21614 +34 Flags with carried forward coverage won't be shown. Click here to find out more.
|
ekcoh
requested changes
Mar 13, 2026
Packages/com.unity.inputsystem/InputSystem/Utilities/ArrayHelpers.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Utilities/ArrayHelpers.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Utilities/ArrayHelpers.cs
Outdated
Show resolved
Hide resolved
K-Tone
changed the title
Collaborator
Author
|
@u-pr can you check if all comments are resolved now? |
Contributor
|
Yes, all comments from previous reviews appear to be resolved in the latest changes:
🤖 Helpful? 👍/👎 |
Collaborator
Author
|
CC @Pauliusd01 for viz - this is some internal thing fixed, not sure if you want to be a reviewer on this one. |
ekcoh
approved these changes
Mar 27, 2026
Collaborator
ekcoh
left a comment
ekcoh
left a comment
There was a problem hiding this comment.
Thanks for addressing the things found in review.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Practically, our ArrayHelpers.Merge implementation doesn't use the supplied comparer to compare elements when merging, instead it will search for comparer in the second array. That's clearly wrong. Fixed that, and also a few other things as we go, added some new test coverage.
Made-with: Cursor
Testing status & QA
Local testing, CI run pending
Overall Product Risks
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.