Skip to content

FIX: Only dispatch when there is a valid selected item #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josepmariapujol-unity merged 2 commits into from
Mar 16, 2026
Merged

FIX: Only dispatch when there is a valid selected item #2383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58fc4fb
Fix: Only dispatch when there is a valid selected item
josepmariapujol-unity Mar 16, 2026
daa83e8
Fix NullReferenceException and improve Input System
josepmariapujol-unity Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Packages/com.unity.inputsystem/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Fixed

- Fixed a `NullReferenceException` thrown when removing all action maps [UUM-137116](https://jira.unity3d.com/browse/UUM-137116)
- Simplified default setting messaging by consolidating repetitive messages into a single HelpBox.
- Fixed a `NullPointerReferenceException` thrown in `InputManagerStateMonitors.FireStateChangeNotifications` logging by adding validation [UUM-136095].
Comment thread
josepmariapujol-unity marked this conversation as resolved.
- Fixed auto-save not working for Input System actions in Project Settings when both the Project Settings and Input System Actions windows were open [UUM-134035](https://jira.unity3d.com/browse/UUM-134035)
Expand Down
3 changes: 2 additions & 1 deletion Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ActionMapsView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ public ActionMapsView(VisualElement root, StateContainer stateContainer)
m_ListViewSelectionChangeFilter = new CollectionViewSelectionChangeFilter(m_ListView);
m_ListViewSelectionChangeFilter.selectedIndicesChanged += (selectedIndices) =>
Comment thread
josepmariapujol-unity marked this conversation as resolved.
{
Dispatch(Commands.SelectActionMap(((ActionMapData)m_ListView.selectedItem).mapName));
if (m_ListView.selectedItem is ActionMapData mapData)
Dispatch(Commands.SelectActionMap(mapData.mapName));
};

m_ListView.bindItem = (element, i) =>
Expand Down
Loading