DOCS: Rumble support for iOS and Android#2420
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2420 +/- ##
============================================
- Coverage 78.13% 58.71% -19.42%
============================================
Files 483 736 +253
Lines 98770 135564 +36794
============================================
+ Hits 77169 79596 +2427
- Misses 21601 55968 +34367
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: anjalin14 <anjali.nabar@unity3d.com>
|
|
|
@anjalin14 can you check iOS part |
Yes will take a look in some time. The note is grown bigger, might be a good idea to move that content out. Adding @suearkinunity package writer here for advice. |
suearkinunity
left a comment
suearkinunity
left a comment
There was a problem hiding this comment.
Left three suggestions, and approved.
Co-authored-by: Sue Arkin <85237015+suearkinunity@users.noreply.github.com>
Co-authored-by: Sue Arkin <85237015+suearkinunity@users.noreply.github.com>
Co-authored-by: Sue Arkin <85237015+suearkinunity@users.noreply.github.com>
Co-authored-by: anjalin14 <anjali.nabar@unity3d.com>
Co-authored-by: anjalin14 <anjali.nabar@unity3d.com>
duplicates in latest docs, can you take a look |
sorry, looks like something went wrong when I added that comment. Could you please remove the duplicate part? |
|
As the PR includes a term related to "Switch", I'm following up with a relevant contact to double-check compliance with NDA terms. Will get back once I hear back from them. |
anjalin14
left a comment
anjalin14
left a comment
There was a problem hiding this comment.
Added suggestions to mention "Nintendo" for Switch Controllers/Switch Pro Controllers per guidance received from the Nintendo contact.
Co-authored-by: anjalin14 <anjali.nabar@unity3d.com>
|
@jfreire-unity would you mind merging this PR if all is good ? |
|
@jfreire-unity it looks like trunk introduced new requirement https://unity-ci.cds.internal.unity3d.com/job/69312383?utm_source=github, DEVELOPMENT_BUILD define cannot be used. Is this something input team is looking at ? |
We are not planning in supporting 6.6 with this package at this time. We fixed the problem in 6.6 for the Module work we're doing. I'll just ignore that CI failure for now. |
|
@anjalin14 just in case, iOS part was removed |
|
@jfreire-unity CI is green as far as I can tell, could you merge this PR in ? |
5 participants
Description
https://jira.unity3d.com/browse/PLAT-19240
Unity 6.6 introduces rumble support for Android and iOS:
Both of the changes above hook into existing https://docs.unity3d.com/Packages/com.unity.inputsystem@1.0/api/UnityEngine.InputSystem.Gamepad.html#UnityEngine_InputSystem_Gamepad_SetMotorSpeeds_System_Single_System_Single_ API, thus there's no changes in input system package.
This PR only adds docs to notify user of what is supported.
Also see this doc - https://docs.google.com/document/d/17PNAd5JGz9MLTzSq5oSnJtJQPJfemLu9XPvV4LE6rjY/edit?tab=t.0#heading=h.oqdem6yytwi9 which provides a matrix of what is supported on Android
Testing status & QA
N/A
Overall Product Risks
N/A