Skip to content

Develop#33

Merged
Rene-Damm merged 23 commits intoUnity-Technologies:developfrom
jackpr-unity:develop
Feb 27, 2018
Merged

Develop#33
Rene-Damm merged 23 commits intoUnity-Technologies:developfrom
jackpr-unity:develop

Conversation

@jackpr-unity
Copy link
Contributor

Adding a scene to test the legacy input system. This one-panel scene sanity-checks kb, mouse, gamepad, button/axis mapping, UI, touchscreens, and IMU data.

using UnityEngine.UI;

[RequireComponent(typeof(Image))]
public class ImageRedIfMultiTouchEnabled : MonoBehaviour {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run format.

using UnityEngine.UI;

[RequireComponent(typeof(Text))]
public class ShowIMUData : MonoBehaviour
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does IMU stand for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMU = Inertial motion unit. It's the term for the physical modules that measure and report acceleration, gyroscope, and magnetometer (compass) data. Does Unity have a better term for grouping all this data together, or is this your way of telling me that my class name can't have non-standard acronyms?

path: Assets/Demo/Demo.unity
guid: 3b868b211075646d5a6a9e07c61071b6
path: Assets/QA/Tests/LegacyInputManager/ISX_LegacyInputManager.unity
guid: 22a9cbef8d392f8409518c5174c25986
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry didn't catch that before. Please revert this change.

@jackpr-unity
Copy link
Contributor Author

How does this fork look now - ok to pull in?

Copy link
Contributor

@Rene-Damm Rene-Damm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the unrelated changes after the merge.

externalObjects: {}
userData:
assetBundleName:
assetBundleVariant:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When committing with git, please stage only the files that you actually want to touch instead of staging every modified file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one here adds a file back that was moved elsewhere.

m_WorldBounds:
m_Center: {x: 0, y: 0, z: 0}
m_Extent: {x: 250, y: 250, z: 250}
m_WorldSubdivisions: 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as for comment above. This one downgrades ProjectSettings to a previous version of Unity.

@Rene-Damm Rene-Damm merged commit 06bfe83 into Unity-Technologies:develop Feb 27, 2018
Rene-Damm pushed a commit that referenced this pull request Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants