FIX: Bindings not getting sync'd when renaming/deleting control schemes. #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rene-Damm
changed the title
jechter
approved these changes
Aug 23, 2019
douglas-piconi
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting and renaming control schemes didn't update bindings so old binding groups were left lying around.
Also, the editor allowed you to add control schemes with empty names.
There's one more problem I didn't yet find a good solution for. ATM you can add bindings to control schemes that use devices not required by the control scheme. In most cases, that won't work correctly when used. We should probably check in
InputBindingPropertiesViewboth when toggling the control scheme mask as well as when setting a binding whether there's a mismatch with the control scheme and if so, pop up a dialog to allow the user to choose a solution.There's one unrelated change in here. I removed code for
basedOnfromInputControlSchemeas the feature was never functional.