Several minor fixes #807
Merged
Several minor fixes #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jechter
requested review from
Rene-Damm and
douglas-piconi
and removed request for
douglas-piconi
Rene-Damm
approved these changes
Aug 27, 2019
douglas-piconi
approved these changes
Aug 27, 2019
Rene-Damm
reviewed
Aug 27, 2019
| { | ||
| m_Button.enabled = false; | ||
| m_Text.text = "Press button/stick for " + name; | ||
| m_RebindOperation?.Dispose(); |
Contributor
There was a problem hiding this comment.
Unrelated but just realized that after the recent change to ToHumanReadableString, line 131 should be
m_Text.text = InputControlPath.ToHumanReadableString(m_Action.bindings[0].effectivePath,
InputControlPath.HumandReadableStringOptions.OmitDevice);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fix grammer in "Do you want to enable the backends?" dialog
-Fix text field focus when deleting interactions/processors
-Some small fixes for tanks demo wrt rebinding