FIX: Compile errors when using C# reserved identifiers in assets. #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglas-piconi
approved these changes
Oct 16, 2019
jechter
approved these changes
Oct 21, 2019
Contributor
jechter
left a comment
jechter
left a comment
There was a problem hiding this comment.
Makes sense. What if I name the class itself like a keyword, though? Anything preventing that atm?
Contributor
Author
Agree it should protect against that. Improved a bit to at least handle it for class names. Will leave making it more robust for later. For certain names, the generator should probably raise errors and not generate code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://fogbugz.unity3d.com/f/cases/1189861/ https://issuetracker.unity3d.com/product/unity/issues/guid/1189861/.