This repository was archived by the owner on Nov 30, 2020. It is now read-only.
Fixed issue with camera physical mode not enableable with postprocess… #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was actually thinking that this was happening because of Cinemachine, thank you for the commit. Greets, |
Chman
suggested changes
May 2, 2018
Contributor
Chman
left a comment
Chman
left a comment
There was a problem hiding this comment.
See the comments for the requested changes.
Let's talk more about it on Slack :)
…Layer, fixed lensShift ignored when using TAA, updated DoF to use physical cam focal length and LookAtConstraint target to calculate focus distance
…f and camera has no LookAtConstraint
Thomasch-unity3d
force-pushed
the
physical-camera-support
branch
from
2609f3e to
2b388ca
Compare
|
Tested in 2018.3.0a11 and 2018.2.6f1 |
JoelFortin
approved these changes
Aug 29, 2018
Chman
approved these changes
Aug 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Layer, fixed lensShift ignored when using TAA, updated DoF to use physical cam focal length and LookAtConstraint target to calculate focus distance.