This repository was archived by the owner on Nov 30, 2020. It is now read-only.
Merged
Conversation
mikesfbay
approved these changes
Nov 8, 2018
Contributor
mikesfbay
left a comment
mikesfbay
left a comment
There was a problem hiding this comment.
This should be fine. Passed tests on Oculus Rift with single-pass instancing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetIntandSetGlobalIntwere introduced in 2018.1. Unfortunately using them breaks compatibility with previous versions of Unity and post-processing v2 needs to stay compatible with 2017.x.I changed the int to a float, given that it's used as a depth slice it should be fine in this case but I don't have the necessary hardware to test on so I'll let you confirm that it indeed works. Feel free to ping me up on slack!