[FEAT]Multiple video capturer #73
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the access modifiers from public to internal or protected.
add AudioStreamTrack.
public modify to internal.
# Conflicts: # Assets/Scripts/RenderStreaming.cs
…ream CaptureAudioStream
todo: 1.create multiple resolution texture for nvEncoder. 2.Abstract out a base class BaseEncoder. Derive AmdEncoder and softEncoder.
karasusan
reviewed
Jul 16, 2019
|
Currently, |
|
Could you add auto testing to check multiple video tracks? |
karasusan
reviewed
Jul 23, 2019
|
I will test this PR on my PC |
karasusan
reviewed
Aug 5, 2019
| } | ||
|
|
||
| void NvEncoder::InitEncoder(int width, int height) | ||
| void NvEncoder::InitEncoder(int width, int height, int _bitRate) |
There was a problem hiding this comment.
Could you keep the naming rules?
_bitRate to bitRate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decoupling video stream(audio stream) and video track(audio track). all capturers share one encoder.