Invaders: Fix various bugs, changes graphics and upgrade to 2020.3.13LTS #14

Cosmin-B · 2021-07-19T08:13:11Z

Game - rename all our alien prefabs to have a more generic name, the same principle was applied to our codebase, renamed variables/fields/classes to something more generic
Game: Fix a crash in shipping build
Enemies: Rename our main enemy class to EnemyAgent + minor clean-ups + implement a grace shoot timer period
Rename AllienBullet to Enemy Bullet
InvadersGame: Some big refactories here, the UpdateEnemies function not outputs a set of flags (bitmask) rather than having separated booleans to keep track off
InvadersGame: Fix an edge case of the game loop where if the enemies would reach the bottom they would never respawn, now when they do reach that bottom boundary it will be game over
InvadersGame: Introduce additional game over reasons
LobbyControl: Introduce a minimum player count variable that could be tweaked in the inspector so that the users can start playing in the editor with just the host in the lobby
PlayerControl: Unified the NotifyGameOver function with the InvadersGame one + added different texts for all the possible game over reasons to be displayed

… and refactoring passes, read below - Game - rename all our alien prefabs to have a more generic name, the same principle was applied to our codebase, renamed variables/fields/classes to something more generic - Enemies: Rename our main enemy class to EnemyAgent + minor clean-ups + implement a grace shoot timer period - Rename AllienBullet to Enemy Bullet - InvadersGame: Some big refactories here, the UpdateEnemies function not outputs a set of flags (bitmask) rather than having separated booleans to keep track off - InvadersGame: Fix an edge case of the game loop where if the enemies would reach the bottom they would never respawn, now when they do reach that bottom boundary it will be game over - InvadersGame: Introduce additional game over reasons - LobbyControl: Introduce a minimum player count variable that could be tweaked in inspector so that the users can start playing in editor with just the host in the lobby - PlayerControl: Unified the NotifyGameOver function with the InvadersGame one + added different texts for all the possible game over reasons to be displayed

Updated all enemy, player and saucer graphics

Basic/Invaders/Assets/Scripts/EnemyAgent.cs

LukeStampfli · 2021-07-19T08:23:22Z

Basic/Invaders/Assets/Scripts/EnemyAgent.cs

+
+    protected void OnDestroy()
+    {
+        if (!InvadersGame.Singleton) return;


same here, maybe explicit InvadersGame.Singleton != null. There's a bunch of these over the code base.

Basic/Invaders/Assets/Scripts/InvadersGame.cs

Co-authored-by: Luke Stampfli <43687322+LukeStampfli@users.noreply.github.com>

LukeStampfli

Looks all good, added some comments for minor stylistic changes which could be made.

… instances

LukeStampfli · 2021-07-21T09:01:42Z

CHANGELOG.md

@@ -1,5 +1,25 @@
 # Change log

+## Invaders - 2021-07-20


Version 0.1.1?

* chore: updated README * chore: Apply suggestions from code review Co-authored-by: Vic Cooper <vic.cooper@unity3d.com> --------- Co-authored-by: Paolo Abela <rikudefuffs@gmail.com> Co-authored-by: Vic Cooper <vic.cooper@unity3d.com>

* feat: dgs core [MTT-6058] (#1) * Creating base project based on NGO template * feat: adding dedicated server package to DGS sample [MTT-6834] (#2) * Adding dedicated server package * enabling content selection and stripping rendering, UI, and Audio components on servers * using multiplayer role instead of configuration to define if server or client * Adding scene bootstrapper from Boss Room * Adding multiplayerRoleRestricted attribute to relevant scripts * updating to MPPM 0.5.0 * refactored game application and gamestate to isolate client and server code * Adding min number of players to config and using max from config * Shutting down the server after game ends or all clients disconnect * setting vsync count to 0 on servers * setting multiplayer role when building via BuildProcessor.cs * updating project editor version to 2023.3.0a7 * Updating CLIArgParser to use CLI Arguments from DedicatedServer * removing port and server ip from config file * Adding default config to additional build files * enabling dedicated server build optimizations in player settings * feature: adding DGS sample to CI [MTT-7459] (#3) * split the pr trigger and build jobs in separate files * moving test-editors as fields under each project, and adding the dgs sample to projects * adding tests to CI * renaming project to remove spaces in name * Adding support to build Linux/Mac/Windows clients and servers through menus * feat: player character and base level design [MTT-6059][MTT-7372][MTT-6063] (#5) * adding com.unity.multiplayer.samples.coop package * Adding third person starter assets * adding back animation module and updating assembly dependencies * adding starter assets asmdef * creating player character * creating environment * cleaning up UI and adding quit button * adding menu toggle action * cleaning up disconnect flow * setting builds to windowed mode * Adding game menu * displaying number of connected players * feat: DGS Sample AI characters [MTT-6062] (#6) * creating basic AI character patrolling between points * using NetcodeHooks class for spawn and despawn hooks * extracting character geometry and skeleton to prefabs * replacing network variable with rpc * updating mac image to more recent one * feature: add readme to DGS sample (#7) * creating readme file * adding UGS setup instructions * syntax fixes and adding links to package docs * Apply suggestions from code review Co-authored-by: Vic Cooper <vic.cooper@unity3d.com> * add details for how to use MPPM * clarifying local multiplayer flow * removing doc link to page that doesnt exist yet * clarifying how to use autoconnect mode * Apply suggestions from code review Co-authored-by: Vic Cooper <vic.cooper@unity3d.com> * adding link to doc for port forwarding * Apply suggestions from code review Co-authored-by: Vic Cooper <vic.cooper@unity3d.com> * Apply suggestions from code review Co-authored-by: Vic Cooper <vic.cooper@unity3d.com> Co-authored-by: Louis-Philippe Lafontaine-Bédard <louisphilippe.lb@unity3d.com> * [Documentation] Removed useless section * [Documentation] Applied feedback from PR * Update Experimental/DedicatedGameServer/README.md Co-authored-by: Vic Cooper <vic.cooper@unity3d.com> * Apply suggestions from code review Co-authored-by: Vic Cooper <vic.cooper@unity3d.com> * chore: updated readme with suggestions * Update Experimental/DedicatedGameServer/README.md Co-authored-by: Vic Cooper <vic.cooper@unity3d.com> * Update Experimental/DedicatedGameServer/README.md Co-authored-by: Vic Cooper <vic.cooper@unity3d.com> * chore: Fixed typos --------- Co-authored-by: Vic Cooper <vic.cooper@unity3d.com> Co-authored-by: Paolo Abela <paolo.abela@unity3d.com> Co-authored-by: Paolo Abela <rikudefuffs@gmail.com> * Project version upgrade + mini fix [MTT-7789] (#10) * chore: updated project version to alpha 17 * chore: Updated multiplayer packages * chore: reserealized proejct settings * fix: stripped AICharacter animator component from server instances * chore: disabled default network prefabs generation [skip ci] * feat: removed Bootstrapper tool [MTT-7632] (#11) * feat: removed Bootstrapper tool and used serialized fields instead [MTT-7632] * fix: fixed faulty initialization due to race conditions * chore: added comments and error logs * Doors integration [MTT-6061] (#12) * importing door scripts, models and animations from boss room * adding doors to environment * changing match duration to 5 minutes * feat: Added logic that allows doors to be opened if at least one player is nearby, and to display the related UI on clients chore: removed FloorSwitch assets * feat: players can now be detected by doors when they collide * feat: added "OpenDoor" input detection * feat: doors open when a player asks them to do so --------- Co-authored-by: LPLafontaineB <louisphilippe.lb@unity3d.com> * chore: updated multiplayer packages to solve UGS integration issues * DGS door UI (#13) * feat: Added predicted and reconciled UI for InteractiveDoor * fix: fixed scaling of door interaction UI * chore: updated CI windows image --------- Co-authored-by: Paolo Abela <rikudefuffs@gmail.com> * DGS readme corrections [MTT-7869] (#14) * chore: updated README * chore: Apply suggestions from code review Co-authored-by: Vic Cooper <vic.cooper@unity3d.com> --------- Co-authored-by: Paolo Abela <rikudefuffs@gmail.com> Co-authored-by: Vic Cooper <vic.cooper@unity3d.com> * Feature: Dedicated Game Server Sample Art Pass [MTT-7403] (#8) * URP settings updates: deleted 2D version and replaced with 3D version * added colors and landmarks to the enviro, reorganized enviro prefab * updated UI with stylesheet from other samples * Added character color shader * updated player colors * Color updates and the addition of player icons * Reorg of environment prefab, reimplementation of character numbers * deletion of unneeded assets * removed debugging method * adjusted URP asset to minimize shadow artifacts * environment tweaks * slightly update door UI * moved a pillar to be in desired position * chore: Updated NGO to 1.8.0 to match the version ran in the CI * deleted unused script * made unnecessarily public class internal, also cleaned out some redundant code --------- Co-authored-by: Paolo Abela <paolo.abela@unity3d.com> * [DGS] Unneded systems strip [MTT-8054] (#15) * chore: added missing newline to readme * chore: optimization. stripped out all default rendering, UI and audio components * Fixed incorrect CI settings (#16) * chore: fixed CI tests not running properly * chore: (CI) updated Windows image and added specific editor version * chore: (CI) updated mac image * chore: updated dedicated server and multiplayer play mode packages to 1.0.0 (#18) * chore: updated documentation links * chore: removed unneeded folders * chore: added instructions related to how to change the amount of players in a section [skip ci] --------- Co-authored-by: Louis-Philippe Lafontaine-Bédard <louisphilippe.lb@unity3d.com> Co-authored-by: Vic Cooper <vic.cooper@unity3d.com> Co-authored-by: Paolo Abela <paolo.abela@unity3d.com> Co-authored-by: Fernando Cortez <fernando.cortez@unity3d.com> Co-authored-by: Jil Franco <jillian.franco@unity3d.com>

Cosmin-B and others added 3 commits July 13, 2021 14:20

Added Graphics (replaces old Alien and Saucer style art)

9ec4d5f

Updated all enemy, player and saucer graphics

[InvadersGame] Fix a crash in shipping builds

0a81ca4

Cosmin-B requested a review from LukeStampfli July 19, 2021 08:13

Cosmin-B assigned LukeStampfli Jul 19, 2021

LukeStampfli reviewed Jul 19, 2021

View reviewed changes

Basic/Invaders/Assets/Scripts/EnemyAgent.cs Outdated Show resolved Hide resolved

LukeStampfli reviewed Jul 19, 2021

View reviewed changes

Basic/Invaders/Assets/Scripts/InvadersGame.cs Outdated Show resolved Hide resolved

Cosmin-B and others added 2 commits July 19, 2021 09:31

Update Basic/Invaders/Assets/Scripts/EnemyAgent.cs

585a9a9

Co-authored-by: Luke Stampfli <43687322+LukeStampfli@users.noreply.github.com>

Update Basic/Invaders/Assets/Scripts/InvadersGame.cs

4ee8652

Co-authored-by: Luke Stampfli <43687322+LukeStampfli@users.noreply.github.com>

LukeStampfli approved these changes Jul 19, 2021

View reviewed changes

Cosmin-B added 3 commits July 19, 2021 14:16

[Assets] Remove all the old assets from the project!

99e5427

[Player] Fix a minor issue where the player is not "Destroyed" on all…

5983e16

… instances

[Project] Add new Invaders changelog

7b80360

LukeStampfli reviewed Jul 21, 2021

View reviewed changes

CHANGELOG.md

@@ -1,5 +1,25 @@

# Change log

## Invaders - 2021-07-20

Copy link

Contributor

LukeStampfli Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 0.1.1?

Cosmin-B merged commit dc9f242 into main Jul 21, 2021

fernando-cortez deleted the feature/invaders branch December 13, 2022 20:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Invaders: Fix various bugs, changes graphics and upgrade to 2020.3.13LTS #14

Invaders: Fix various bugs, changes graphics and upgrade to 2020.3.13LTS #14

Uh oh!

Cosmin-B commented Jul 19, 2021 •

edited

Loading

Uh oh!

Uh oh!

LukeStampfli Jul 19, 2021 •

edited

Loading

Uh oh!

Uh oh!

LukeStampfli left a comment

Uh oh!

LukeStampfli Jul 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Invaders: Fix various bugs, changes graphics and upgrade to 2020.3.13LTS #14

Invaders: Fix various bugs, changes graphics and upgrade to 2020.3.13LTS #14

Uh oh!

Conversation

Cosmin-B commented Jul 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

LukeStampfli Jul 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LukeStampfli left a comment

Choose a reason for hiding this comment

Uh oh!

LukeStampfli Jul 21, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Cosmin-B commented Jul 19, 2021 •

edited

Loading

LukeStampfli Jul 19, 2021 •

edited

Loading